Add tests cases for malformed and conflicting patches #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
requested changes
Feb 11, 2025
| func TestPatchSource_MalformedPatch(t *testing.T) { | ||
| worker := llb.Scratch() | ||
| sourceState := llb.Scratch().File( | ||
| llb.Mkfile("/file.txt", 0644, []byte("Hello World")), |
There was a problem hiding this comment.
Can you use the updated octal format 0o644 for everything?
| }, | ||
| } | ||
|
|
||
| assert.Assert(t, func() { |
There was a problem hiding this comment.
It looks like this is testing that the closure is not nil which doesn't look correct.
I think the easiest way to test these is in the integration tests (under test/) where we can get it to actually run the patch and produce an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: We need to test to ensure we fail when a patch is either malformed or conflicts with another patch.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #500
Special notes for your reviewer: