Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RTT storybook to match conceptual doc #5657

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update RTT storybook to match conceptual doc #5657

wants to merge 2 commits into from

Conversation

carocao-msft
Copy link
Contributor

What

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

@carocao-msft carocao-msft added the does not need changelog Changes that does not affect the published package in any way do not need changelog entry label Feb 20, 2025
@carocao-msft carocao-msft requested review from a team as code owners February 20, 2025 00:41
@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jtltjyylek.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 28000 / 44676
62.67%		 28000 / 44676
62.67%		 786 / 1436
54.73%		 2340 / 3712
63.03%
Current 28005 / 44676
62.68%		 28005 / 44676
62.68%		 786 / 1436
54.73%		 2339 / 3709
63.06%
Diff 5 / 0
0.01%		 5 / 0
0.01%		 0 / 0
0%		 -1 / -3
0.03%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2025 •
edited
Loading

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58216 / 94212
61.79%		 58216 / 94212
61.79%		 1177 / 2693
43.7%		 3532 / 5821
60.67%
Current 58199 / 94212
61.77%		 58199 / 94212
61.77%		 1177 / 2693
43.7%		 3480 / 5792
60.08%
Diff -17 / 0
-0.02%		 -17 / 0
-0.02%		 0 / 0
0%		 -52 / -29
-0.59%

Copilot
Copilot AI reviewed Feb 20, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
@github-actions GitHub Actions
Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1777281
  • Base size: 1777281
  • Diff size: 0

@github-actions GitHub Actions
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

edwardlee-msft
edwardlee-msft reviewed Feb 20, 2025
View reviewed changes
packages/storybook8/stories/Concepts/RealTimeText/Docs.mdx

### What versions of UI Library support RTT?

RTT is currently in public preview and supported in 1.24.0-beta.1.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it better to just have a banner on top indicating that it's in public preview instead of having a section here indicating a version #?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to update this to stable version once it is out in stable. This is in the conceptual doc Tay wrote

@github-actions GitHub Actions
Copy link
Contributor

Storybook 8 URL https://60c7ae6891f0e90039d7cd54-jpynarhwxg.chromatic.com/

edwardlee-msft
edwardlee-msft reviewed Feb 20, 2025
View reviewed changes
packages/storybook8/stories/Concepts/RealTimeText/Docs.mdx

### When I type a sentence in the RTT window, when does it get sent?

A message is finalized (or "committed") when the user explicitly takes an action, such as pressing "Enter," or if no additional text is typed for 3 seconds, at which point the text will automatically commit.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the question asks about "sent"
But the answer never mentions sent. Rather it mentions "Finalized" and "committed". Should we somewhere indicate sent = finalized? If that's what they are specifically asking here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check with Tay on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardlee-msft edwardlee-msft edwardlee-msft left review comments

Copilot code review Copilot Copilot left review comments

@mgamis-msft mgamis-msft mgamis-msft approved these changes

@JamesBurnside JamesBurnside Awaiting requested review from JamesBurnside JamesBurnside is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@alkwa-msft alkwa-msft Awaiting requested review from alkwa-msft alkwa-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@dmceachernmsft dmceachernmsft Awaiting requested review from dmceachernmsft dmceachernmsft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-1

@prabhjot-msft prabhjot-msft Awaiting requested review from prabhjot-msft prabhjot-msft is a code owner automatically assigned from Azure/acs-ui-web-calling-reviewer-2

@jimchou-dev jimchou-dev Awaiting requested review from jimchou-dev jimchou-dev is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@vhuseinova-msft vhuseinova-msft Awaiting requested review from vhuseinova-msft vhuseinova-msft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@Leah-Xia-Microsoft Leah-Xia-Microsoft Awaiting requested review from Leah-Xia-Microsoft Leah-Xia-Microsoft is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@jpeng-ms jpeng-ms Awaiting requested review from jpeng-ms jpeng-ms is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-1

@waynemo waynemo Awaiting requested review from waynemo waynemo is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@emlynmac emlynmac Awaiting requested review from emlynmac emlynmac is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@JoshuaLai JoshuaLai Awaiting requested review from JoshuaLai JoshuaLai is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

@palatter palatter Awaiting requested review from palatter palatter is a code owner automatically assigned from Azure/acs-ui-web-chat-reviewer-2

At least 2 approving reviews are required to merge this pull request.

Assignees

@mgamis-msft mgamis-msft

@edwardlee-msft edwardlee-msft

Labels
does not need changelog Changes that does not affect the published package in any way do not need changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carocao-msft @mgamis-msft @edwardlee-msft