-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix move/close menu not showing on draggable video tile when ctrl+alt+space shortcut is used #5652
Conversation
… ctrl+alt+space shortcut is used
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-eesirpoxhj.chromatic.com/ |
@azure/communication-react jest test coverage for stable.
|
@azure/communication-react jest test coverage for beta.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (2)
- change-beta/@azure-communication-react-efaa1c36-cd40-48ac-8905-e7c88a135523.json: Language not supported
- change/@azure-communication-react-efaa1c36-cd40-48ac-8905-e7c88a135523.json: Language not supported
Comments suppressed due to low confidence (2)
packages/react-components/src/components/ModalClone/ModalClone.tsx:93
- Changing the event type from React.KeyboardEvent to KeyboardEvent might cause type mismatches or runtime errors if the function is called with a React.KeyboardEvent. Ensure all call sites are updated accordingly.
const getMoveDelta = (ev: KeyboardEvent): number => {
packages/react-components/src/components/ModalClone/ModalClone.tsx:154
- Using window as the default value for keyEventElement might lead to unexpected behavior in environments where window is not available, such as server-side rendering. Ensure window is always available or provide a fallback mechanism.
keyEventElement = window
CallWithChat bundle size is not changed.
|
Chat bundle size is not changed.
|
Calling bundle size is not changed.
|
Storybook 8 URL https://60c7ae6891f0e90039d7cd54-rkcfryznbq.chromatic.com/ |
What
forceUpdateCallback
that triggers a rerender to remove themove
icon, the icon wasn't being removed in react18 due to the render optimizations; there is no set state triggering a re-render and no longer an unrelated re-render occurringkeyEventElement
so window doesn't have to be used (not being used by component or composite currently as it would be a larger change with an API change, no regression in continuing to use window object for now)Why
React 18 strict mode broke the a11y menu for the draggable tile, see recording below for menu being fixed
How Tested
move-keyboard-recording.mp4