Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show you're muted notification on lobby screen #5651

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

JamesBurnside
Copy link
Member

What

Filter You're Muted notification to only show when the call is connected

Why

Bug fix: Do not show you're muted notification on lobby screen

How Tested

Ran locally (windows) and did not see notification on the lobby screen

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • change-beta/@azure-communication-react-430704ce-69fc-4b1a-b79d-623307613475.json: Language not supported
  • change/@azure-communication-react-430704ce-69fc-4b1a-b79d-623307613475.json: Language not supported
Copy link
Contributor

github-actions bot commented Feb 14, 2025

@azure/communication-react jest test coverage for stable.

Lines Statements Functions Branches
Base 27998 / 44674
62.67%
27998 / 44674
62.67%
786 / 1436
54.73%
2340 / 3712
63.03%
Current 28053 / 44676
62.79%
28053 / 44676
62.79%
786 / 1436
54.73%
2329 / 3711
62.75%
Diff 55 / 2
0.12%
55 / 2
0.12%
0 / 0
0%
-11 / -1
-0.28%

Copy link
Contributor

github-actions bot commented Feb 14, 2025

@azure/communication-react jest test coverage for beta.

Lines Statements Functions Branches
Base 58275 / 94205
61.85%
58275 / 94205
61.85%
1177 / 2693
43.7%
3547 / 5838
60.75%
Current 58270 / 94212
61.84%
58270 / 94212
61.84%
1177 / 2693
43.7%
3505 / 5815
60.27%
Diff -5 / 7
-0.01%
-5 / 7
-0.01%
0 / 0
0%
-42 / -23
-0.48%

@JamesBurnside JamesBurnside enabled auto-merge (squash) February 20, 2025 18:38
Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Chat bundle size is not changed.

  • Current size: 1777281
  • Base size: 1777281
  • Diff size: 0

@JamesBurnside JamesBurnside merged commit a29bb63 into main Feb 20, 2025
40 checks passed
@JamesBurnside JamesBurnside deleted the jaburnsi/lobby-muted-notification branch February 20, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants