Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hideAvatar to onFetchAvatarPersonaData API #5646

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Leah-Xia-Microsoft
Copy link
Member

What

  • This PR is to add the ability to hide the entire avatar element in the composite level.
  • Also at the component level, if Contoso developer passes in an empty element <></> to the onRenderAvatar, this PR removes the unnecessary left margin
  • Since we're only adding a new optional prop to the onFetchAvatarPersonaData API, it won't be a breaking change

Why

How Tested

Process & policy checklist

  • I have updated the project documentation to reflect my changes if necessary.
  • I have read the CONTRIBUTING documentation.

Is this a breaking change?

  • This change causes current functionality to break.

Copy link
Contributor

CallWithChat bundle size is not changed.

  • Current size: 12401112
  • Base size: 12401112
  • Diff size: 0

Copy link
Contributor

Chat bundle size is increased❗.

  • Current size: 1777363
  • Base size: 1777255
  • Diff size: 108

Copy link
Contributor

Calling bundle size is not changed.

  • Current size: 12401100
  • Base size: 12401100
  • Diff size: 0

Copy link
Contributor

Failed to pass the composite UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

Failed to pass the UI Test. If this PR is for UI change and the error is snapshot mismatch, please add "update_snapshots" label to the PR for updating the snapshot.

Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant