Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added domainverificationid output #4491

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

cmezach
Copy link
Contributor

@cmezach cmezach commented Feb 21, 2025

Added domainVerificationId to module output

Fixes #4490
Closes #4490

Pipeline Reference

Pipeline
avm.res.app.managed-environment

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@cmezach cmezach requested review from a team as code owners February 21, 2025 09:04
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Feb 21, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 21, 2025
@cmezach cmezach changed the title added domainverificationid Feat: added domainverificationid output Feb 21, 2025
@cmezach cmezach marked this pull request as draft February 21, 2025 09:36
@cmezach cmezach changed the title Feat: added domainverificationid output feat: added domainverificationid output Feb 21, 2025
@cmezach cmezach marked this pull request as ready for review February 21, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: avm/res/app/managed-environment output customDomainVerificationId
2 participants