Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make AvailabilityZone optional and protocolTypes required in the avm/res/net-app/net-app-account module #4468

Closed
wants to merge 4 commits into from

Conversation

thecmdradama
Copy link
Contributor

@thecmdradama thecmdradama commented Feb 18, 2025

Description

This PR resolves the following issues in the avm/res/net-app/net-app-account module

  • On the NetApp Volume submodule, zone has been renamed to availabilityZone.
  • The type for availabilityZone has been changed to string from int[] and is now optional with null as the default. Previously the module would try and deploy in all three zones if no value is defined.
  • Changed: protocolTypes is now an optional array of strings with three possible options 'NFSv3', 'NFSv4.1', and 'CIFS'. If no value is provided, the default value of ['NFSv3'] is used.
  • Added to the description for protocolTypes to specify ['NFSv3','CIFS'] or ['NFSv4.1','CIFS'] if creating dual-stack volumes.
  • Added in additional submodule README.md and main.json files generated by Set-AVMModule.

Pipeline Reference

Pipeline
avm.res.net-app.net-app-account

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 18, 2025

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@thecmdradama thecmdradama marked this pull request as ready for review February 18, 2025 04:56
@thecmdradama thecmdradama requested review from a team as code owners February 18, 2025 04:56
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Feb 18, 2025
@thecmdradama thecmdradama deleted the fix/net-app-pattern branch February 18, 2025 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant