-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New module azure-stack-hci/logical-network module #4464
Open
xhy8759
wants to merge
17
commits into
Azure:main
Choose a base branch
from
Infrastructure-as-code-Automation:hangxu/logicalnetwork
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,636
−0
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
3be55ae
logical network init
58ae03f
update
ebb730c
add tags
167ba1d
update
20f88fd
update version
731e6b6
remove action
9339d44
Revert "remove action"
08dfbad
use default dependency of hci cluster
9410fb2
update
9e29387
update
3208dc3
update
a4d8978
add rbac
a124e88
update
a0ac2ba
update
6724862
update
8ea7ffb
update
85397e1
add depends on
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88 changes: 88 additions & 0 deletions
88
.github/workflows/avm.res.azure-stack-hci.logical-network.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| name: "avm.res.azure-stack-hci.logical-network" | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| staticValidation: | ||
| type: boolean | ||
| description: "Execute static validation" | ||
| required: false | ||
| default: true | ||
| deploymentValidation: | ||
| type: boolean | ||
| description: "Execute deployment validation" | ||
| required: false | ||
| default: true | ||
| removeDeployment: | ||
| type: boolean | ||
| description: "Remove deployed module" | ||
| required: false | ||
| default: true | ||
| customLocation: | ||
| type: string | ||
| description: "Default location overwrite (e.g., eastus)" | ||
| required: false | ||
| push: | ||
| branches: | ||
| - main | ||
| paths: | ||
| - ".github/actions/templates/avm-**" | ||
| - ".github/workflows/avm.template.module.yml" | ||
| - ".github/workflows/avm.res.azure-stack-hci.logical-network.yml" | ||
| - "avm/res/azure-stack-hci/logical-network/**" | ||
| - "avm/utilities/pipelines/**" | ||
| - "!avm/utilities/pipelines/platform/**" | ||
| - "!*/**/README.md" | ||
|
|
||
| env: | ||
| modulePath: "avm/res/azure-stack-hci/logical-network" | ||
| workflowPath: ".github/workflows/avm.res.azure-stack-hci.logical-network.yml" | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }} | ||
|
|
||
| jobs: | ||
| ########################### | ||
| # Initialize pipeline # | ||
| ########################### | ||
| job_initialize_pipeline: | ||
| runs-on: ubuntu-latest | ||
| name: "Initialize pipeline" | ||
| steps: | ||
| - name: "Checkout" | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: "Set input parameters to output variables" | ||
| id: get-workflow-param | ||
| uses: ./.github/actions/templates/avm-getWorkflowInput | ||
| with: | ||
| workflowPath: "${{ env.workflowPath}}" | ||
| - name: "Get module test file paths" | ||
| id: get-module-test-file-paths | ||
| uses: ./.github/actions/templates/avm-getModuleTestFiles | ||
| with: | ||
| modulePath: "${{ env.modulePath }}" | ||
| outputs: | ||
| workflowInput: ${{ steps.get-workflow-param.outputs.workflowInput }} | ||
| moduleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.moduleTestFilePaths }} | ||
| psRuleModuleTestFilePaths: ${{ steps.get-module-test-file-paths.outputs.psRuleModuleTestFilePaths }} | ||
| modulePath: "${{ env.modulePath }}" | ||
|
|
||
| ############################## | ||
| # Call reusable workflow # | ||
| ############################## | ||
| call-workflow-passing-data: | ||
| name: "Run" | ||
| permissions: | ||
| id-token: write # For OIDC | ||
| contents: write # For release tags | ||
| needs: | ||
| - job_initialize_pipeline | ||
| uses: ./.github/workflows/avm.template.module.yml | ||
| with: | ||
| workflowInput: "${{ needs.job_initialize_pipeline.outputs.workflowInput }}" | ||
| moduleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.moduleTestFilePaths }}" | ||
| psRuleModuleTestFilePaths: "${{ needs.job_initialize_pipeline.outputs.psRuleModuleTestFilePaths }}" | ||
| modulePath: "${{ needs.job_initialize_pipeline.outputs.modulePath}}" | ||
| secrets: inherit |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @xhy8759,
thank you for your contribution 💪
For this change, I take it you tested it first without adding the module to this list of exeptions? As the module is deploying role assignments, I'd not be surprised, but it's also not failing for all modules 😄