Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update avm/res/compute/virtual-machine - Deploy vm's with ZRS data disk(s) #4420

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

3891sinneD
Copy link

Possible fix for issue: #3850

Description

Fixes #3850

Pipeline Reference

avm.res.compute.virtual-machine

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@3891sinneD 3891sinneD requested review from a team as code owners February 10, 2025 18:42
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Feb 10, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 10, 2025
@rahalan rahalan self-assigned this Feb 11, 2025
@rahalan
Copy link
Contributor

rahalan commented Feb 13, 2025

@3891sinneD your workflow runs are red. Do you need help to get them green?

@rahalan rahalan removed the Needs: Triage 🔍 Maintainers need to triage still label Feb 13, 2025
@3891sinneD
Copy link
Author

@rahalan Most of the test deployments are green now.
Except for the NVIDIA (quota limit, I've requested an increase but I am on a MSDN subscription...).
And the Linux/Windows max flows:
A valid principal ID must be provided for role assignment.

But i cannot figure out where to provide this ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: virtualmachine error when deploying vm with ZRS datadisk
2 participants