Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log Analytics Workspace updates - API versions and new properties #4418

Merged
merged 11 commits into from
Feb 11, 2025

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Feb 10, 2025

Description

  • update of the API versions
  • new parameter features of the type workspaceFeaturesType added
    • user defined type: workspaceFeaturesType
    • converted the former parameter useResourcePermissions into a property of the features parameter: enableLogAccessUsingOnlyResourcePermissions to align with the template reference
    • new properties of the features object implemented:
      • disableLocalAuth
      • enableDataExport
      • immediatePurgeDataOn30Days
  • update of the test cases to reflect new parameters

Pipeline Reference

Pipeline
avm.res.operational-insights.workspace

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Feb 10, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Feb 10, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Feb 10, 2025

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@krbar krbar changed the title Users/krbar/law update Log Analytics Workspace updates - API version and new properties Feb 10, 2025
@krbar krbar changed the title Log Analytics Workspace updates - API version and new properties Log Analytics Workspace updates - API versions and new properties Feb 10, 2025
@krbar krbar changed the title Log Analytics Workspace updates - API versions and new properties feat: Log Analytics Workspace updates - API versions and new properties Feb 10, 2025
@krbar krbar marked this pull request as ready for review February 10, 2025 20:42
@krbar krbar requested review from a team as code owners February 10, 2025 20:42
@krbar krbar requested a review from Copilot February 10, 2025 20:42
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 28 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • avm/res/operational-insights/workspace/data-export/main.bicep: Language not supported
  • avm/res/operational-insights/workspace/data-export/main.json: Language not supported
  • avm/res/operational-insights/workspace/data-source/main.bicep: Language not supported
  • avm/res/operational-insights/workspace/data-source/main.json: Language not supported
  • avm/res/operational-insights/workspace/linked-service/main.bicep: Language not supported
  • avm/res/operational-insights/workspace/linked-service/main.json: Language not supported
  • avm/res/operational-insights/workspace/linked-storage-account/main.bicep: Language not supported
  • avm/res/operational-insights/workspace/linked-storage-account/main.json: Language not supported
  • avm/res/operational-insights/workspace/main.bicep: Language not supported
  • avm/res/operational-insights/workspace/main.json: Language not supported
  • avm/res/operational-insights/workspace/saved-search/main.bicep: Language not supported
  • avm/res/operational-insights/workspace/saved-search/main.json: Language not supported
  • avm/res/operational-insights/workspace/storage-insight-config/main.bicep: Language not supported
  • avm/res/operational-insights/workspace/README.md: Evaluated as low risk
  • avm/res/operational-insights/workspace/data-export/README.md: Evaluated as low risk
@krbar krbar merged commit ec5d025 into Azure:main Feb 11, 2025
8 checks passed
@krbar krbar deleted the users/krbar/lawUpdate branch February 11, 2025 09:57
anderseide pushed a commit to anderseide/avm-bicep-registry-modules that referenced this pull request Feb 19, 2025
…es (Azure#4418)

## Description

- update of the API versions
- new parameter `features` of the type `workspaceFeaturesType` added
  - user defined type: `workspaceFeaturesType`
- converted the former parameter `useResourcePermissions` into a
property of the `features` parameter:
`enableLogAccessUsingOnlyResourcePermissions` to align with the template
reference
  - new properties of the `features` object implemented:
    - `disableLocalAuth`
    - `enableDataExport`
    - `immediatePurgeDataOn30Days`
- update of the test cases to reflect new parameters

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.operational-insights.workspace](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml/badge.svg?branch=users%2Fkrbar%2FlawUpdate)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [x] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
anderseide pushed a commit to anderseide/avm-bicep-registry-modules that referenced this pull request Feb 23, 2025
…es (Azure#4418)

## Description

- update of the API versions
- new parameter `features` of the type `workspaceFeaturesType` added
  - user defined type: `workspaceFeaturesType`
- converted the former parameter `useResourcePermissions` into a
property of the `features` parameter:
`enableLogAccessUsingOnlyResourcePermissions` to align with the template
reference
  - new properties of the `features` object implemented:
    - `disableLocalAuth`
    - `enableDataExport`
    - `immediatePurgeDataOn30Days`
- update of the test cases to reflect new parameters

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.operational-insights.workspace](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml/badge.svg?branch=users%2Fkrbar%2FlawUpdate)](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [x] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants