-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Log Analytics Workspace updates - API versions and new properties #4418
Conversation
Important The "Needs: Triage 🔍" label must be removed once the triage process is complete! Tip For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation. |
Important If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs). To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label! The core team will only review and approve PRs that have this label applied! |
…into users/krbar/lawUpdate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 13 out of 28 changed files in this pull request and generated no comments.
Files not reviewed (15)
- avm/res/operational-insights/workspace/data-export/main.bicep: Language not supported
- avm/res/operational-insights/workspace/data-export/main.json: Language not supported
- avm/res/operational-insights/workspace/data-source/main.bicep: Language not supported
- avm/res/operational-insights/workspace/data-source/main.json: Language not supported
- avm/res/operational-insights/workspace/linked-service/main.bicep: Language not supported
- avm/res/operational-insights/workspace/linked-service/main.json: Language not supported
- avm/res/operational-insights/workspace/linked-storage-account/main.bicep: Language not supported
- avm/res/operational-insights/workspace/linked-storage-account/main.json: Language not supported
- avm/res/operational-insights/workspace/main.bicep: Language not supported
- avm/res/operational-insights/workspace/main.json: Language not supported
- avm/res/operational-insights/workspace/saved-search/main.bicep: Language not supported
- avm/res/operational-insights/workspace/saved-search/main.json: Language not supported
- avm/res/operational-insights/workspace/storage-insight-config/main.bicep: Language not supported
- avm/res/operational-insights/workspace/README.md: Evaluated as low risk
- avm/res/operational-insights/workspace/data-export/README.md: Evaluated as low risk
…es (Azure#4418) ## Description - update of the API versions - new parameter `features` of the type `workspaceFeaturesType` added - user defined type: `workspaceFeaturesType` - converted the former parameter `useResourcePermissions` into a property of the `features` parameter: `enableLogAccessUsingOnlyResourcePermissions` to align with the template reference - new properties of the `features` object implemented: - `disableLocalAuth` - `enableDataExport` - `immediatePurgeDataOn30Days` - update of the test cases to reflect new parameters ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [x] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
…es (Azure#4418) ## Description - update of the API versions - new parameter `features` of the type `workspaceFeaturesType` added - user defined type: `workspaceFeaturesType` - converted the former parameter `useResourcePermissions` into a property of the `features` parameter: `enableLogAccessUsingOnlyResourcePermissions` to align with the template reference - new properties of the `features` object implemented: - `disableLocalAuth` - `enableDataExport` - `immediatePurgeDataOn30Days` - update of the test cases to reflect new parameters ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [x] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
Description
features
of the typeworkspaceFeaturesType
addedworkspaceFeaturesType
useResourcePermissions
into a property of thefeatures
parameter:enableLogAccessUsingOnlyResourcePermissions
to align with the template referencefeatures
object implemented:disableLocalAuth
enableDataExport
immediatePurgeDataOn30Days
Pipeline Reference
Type of Change
version.json
:version.json
.version.json
.Checklist
Set-AVMModule
locally to generate the supporting module files.