Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Small update to the Type-suffix check for UDTs #4248

Merged
merged 2 commits into from
Jan 21, 2025
Merged

fix: Small update to the Type-suffix check for UDTs #4248

merged 2 commits into from
Jan 21, 2025

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Jan 19, 2025 •
edited
Loading

Description

Changed the regex to also cover cases like _1.privateEndpointCustomDnsConfigType

Pipeline Reference

Pipeline
avm.res.web.static-site (should not show warning)
avm.res.network.dns-forwarding-ruleset (should show warning)

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Jan 19, 2025
@AlexanderSehr AlexanderSehr added Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI labels Jan 19, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 19, 2025
@AlexanderSehr AlexanderSehr marked this pull request as ready for review January 19, 2025 14:24
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner January 19, 2025 14:24
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jan 19, 2025
eriqua
eriqua approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 7e720fa into main Jan 21, 2025
32 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/udtRegexFix branch January 21, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Type: CI 🚀 This issue is related to the AVM CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @eriqua