Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tags parameter to connection monitors and flow logs #4135

Merged
merged 4 commits into from
Jan 9, 2025

Conversation

segraef
Copy link
Contributor

@segraef segraef commented Jan 9, 2025

Description

Fixes #3319

Pipeline Reference

Pipeline
avm.res.network.network-watcher

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Jan 9, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Jan 9, 2025

Important

If this is a module-related PR, being submitted by the sole owner of the module, the AVM core team must review and approve it (as module owners can't approve their own PRs).

To indicate this PR needs the core team''s attention, apply the "Needs: Core Team 🧞" label!

The core team will only review and approve PRs that have this label applied!

@segraef segraef marked this pull request as ready for review January 9, 2025 01:14
@segraef segraef requested review from a team as code owners January 9, 2025 01:14
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jan 9, 2025
@segraef segraef changed the title Users/segraef/3319 feat: Add tags parameter to connection monitors and flow logs Jan 9, 2025
Copy link
Contributor

@AlexanderSehr AlexanderSehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @segraef. Always appreciated 💪

@AlexanderSehr AlexanderSehr merged commit 44836fd into main Jan 9, 2025
24 of 27 checks passed
@AlexanderSehr AlexanderSehr deleted the users/segraef/3319 branch January 9, 2025 07:45
@awood-ops
Copy link

Thanks @segraef 👍🏻

@AlexanderSehr
Copy link
Contributor

Hey @awood-ops,
the new module version will be available once this workflow is finished. The local version cache may not automatically update, but even without it showing up in the BRM dropdown, you'll be able to reference the new version 0.4.0.
PS: The cache will update eventually 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Network Watcher - Flow logs don't pass the tags
3 participants