Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: res/insights/private-link-scope deploys private endpoints in the subnet resource group #4132

Merged
merged 18 commits into from
Feb 14, 2025

Conversation

ReneHezser
Copy link
Contributor

@ReneHezser ReneHezser commented Jan 7, 2025

Description

  • Adds UDTs
  • deploys private endpoint in the subnet resource group, if not explicitly specified

Closes #3835
#4404

Pipeline Reference

Pipeline
avm.res.insights.private-link-scope

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

deploys private endpoints in the subnet subscription
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 7, 2025
@AlexanderSehr
Copy link
Contributor

Hey @ReneHezser,
the linked issue now has been open for a while even though the fix is already rolled out to numerous other modules. Any chance you'll have time to finish this one soon? Alternatively, I could also take a stab at the module and open a PR.

@ReneHezser ReneHezser marked this pull request as ready for review January 30, 2025 18:09
@ReneHezser ReneHezser requested review from a team as code owners January 30, 2025 18:09
@ReneHezser
Copy link
Contributor Author

Hey @ReneHezser, the linked issue now has been open for a while even though the fix is already rolled out to numerous other modules. Any chance you'll have time to finish this one soon? Alternatively, I could also take a stab at the module and open a PR.

Sorry @AlexanderSehr I missed this one.

@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Jan 30, 2025
@ReneHezser ReneHezser merged commit abc57d0 into Azure:main Feb 14, 2025
4 checks passed
@ReneHezser ReneHezser deleted the issue-3835 branch February 14, 2025 15:01
anderseide pushed a commit to anderseide/avm-bicep-registry-modules that referenced this pull request Feb 19, 2025
…he subnet resource group (Azure#4132)

## Description

- Adds UDTs
- deploys private endpoint in the subnet resource group, if not
explicitly specified

Closes Azure#3835 
Azure#4404 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.insights.private-link-scope](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml/badge.svg?branch=issue-3835)](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml)
|

## Type of Change

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings
anderseide pushed a commit to anderseide/avm-bicep-registry-modules that referenced this pull request Feb 23, 2025
…he subnet resource group (Azure#4132)

## Description

- Adds UDTs
- deploys private endpoint in the subnet resource group, if not
explicitly specified

Closes Azure#3835 
Azure#4404 

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.insights.private-link-scope](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml/badge.svg?branch=issue-3835)](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml)
|

## Type of Change

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [x] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Module Owner 📣 This module needs an owner to develop or maintain it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
2 participants