Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update avm/res/api-management/service - WAF Security recommendations #3942

Merged
merged 148 commits into from
Feb 20, 2025

Conversation

ReneHezser
Copy link
Contributor

@ReneHezser ReneHezser commented Dec 17, 2024

Description

Adds WAF Security defaults and UDTs.

Pipeline Reference

Pipeline
avm.res.api-management.service

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue label Dec 17, 2024
@ReneHezser ReneHezser marked this pull request as ready for review December 17, 2024 14:25
@ReneHezser ReneHezser requested review from a team as code owners December 17, 2024 14:25
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Dec 17, 2024
@ReneHezser ReneHezser changed the title Api gateway waf security feat: WAF Security recommendations res/api-management/service Dec 17, 2024
@ReneHezser ReneHezser changed the title feat: WAF Security recommendations res/api-management/service feat: WAF Security recommendations 'res/api-management/service' Dec 17, 2024
@ReneHezser ReneHezser changed the title feat: WAF Security recommendations 'res/api-management/service' feat: WAF Security recommendations res/api-management/service Dec 17, 2024
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Jan 2, 2025
Copy link
Contributor

@tony-box tony-box left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I think just the one fix suggested by @AlexanderSehr and we're good to go. Thanks!

@eriqua eriqua changed the title feat: WAF Security recommendations res/api-management/service feat: Update avm/res/api-management/service - WAF Security recommendations Jan 26, 2025
@eriqua eriqua added the Class: Pattern Module 📦 This is a pattern module label Jan 26, 2025
@ReneHezser
Copy link
Contributor Author

@tony-box the pipeline is green and we are good to merge. There is one open requested change from you, though. Could you please resolve that one?

@tony-box tony-box merged commit ac7a2d6 into Azure:main Feb 20, 2025
4 checks passed
@ReneHezser ReneHezser deleted the api-gateway-waf-security branch February 21, 2025 07:04
anderseide pushed a commit to anderseide/avm-bicep-registry-modules that referenced this pull request Feb 23, 2025
…dations (Azure#3942)

## Description

Adds WAF Security defaults and UDTs.

## Pipeline Reference

| Pipeline |
| -------- |
|
[![avm.res.api-management.service](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.api-management.service.yml/badge.svg?branch=api-gateway-waf-security)](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.api-management.service.yml)
|

## Type of Change

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [x] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

---------

Co-authored-by: Erika Gressi <[email protected]>
Co-authored-by: Alexander Sehr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Pattern Module 📦 This is a pattern module Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants