Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Data-Analytics-Workspace - Several smaller adjustments to enable testing #3651

Merged
merged 13 commits into from
Nov 6, 2024
Merged

fix: Data-Analytics-Workspace - Several smaller adjustments to enable testing #3651

merged 13 commits into from
Nov 6, 2024

Conversation

AlexanderSehr
Copy link
Contributor

Description

  • Disabled purge protection
  • Renamed resources
  • Added dynamic element to deployment names
  • Upgraded used module versions & applied required updates
  • Replaced Lock UDT with import

Pipeline Reference

Pipeline
avm.ptn.data.private-analytical-workspace

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr self-assigned this Oct 28, 2024
@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working Class: Pattern Module 📦 This is a pattern module labels Oct 28, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 28, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 29, 2024 16:15
@AlexanderSehr AlexanderSehr requested review from a team as code owners October 29, 2024 16:15
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 29, 2024 16:15
@avm-team-linter avm-team-linter bot added the Needs: Module Owner 📣 This module needs an owner to develop or maintain it label Oct 29, 2024
@AlexanderSehr AlexanderSehr linked an issue Oct 29, 2024 that may be closed by this pull request
[Failed pipeline] avm.ptn.data.private-analytical-workspace #3598
Closed
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Oct 29, 2024
@AlexanderSehr AlexanderSehr marked this pull request as draft October 30, 2024 10:40
auto-merge was automatically disabled October 30, 2024 10:40

Pull request was converted to draft

@AlexanderSehr AlexanderSehr marked this pull request as ready for review October 30, 2024 15:29
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) October 30, 2024 15:29
@eriqua
Copy link
Contributor

eriqua commented Oct 30, 2024

Lgtm
@jbinko please have a look when you get some time 🙂

@eriqua eriqua added the Needs: Attention 👋 Reply has been added to issue, maintainer to review label Nov 1, 2024
jbinko
jbinko approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@jbinko jbinko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@AlexanderSehr AlexanderSehr merged commit a82f1b0 into main Nov 6, 2024
6 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/pawFix branch November 6, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eriqua eriqua eriqua left review comments

@jbinko jbinko jbinko approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
Class: Pattern Module 📦 This is a pattern module Needs: Attention 👋 Reply has been added to issue, maintainer to review Needs: Module Owner 📣 This module needs an owner to develop or maintain it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Failed pipeline] avm.ptn.data.private-analytical-workspace
3 participants
@AlexanderSehr @eriqua @jbinko