Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements of the avm/res/network/bastion-host module #3611

Merged
merged 13 commits into from
Oct 25, 2024

Conversation

krbar
Copy link
Contributor

@krbar krbar commented Oct 22, 2024

Description

Several improvements of the Azure Bastion module:

  • Updated the API version of Microsoft.Network/bastionHosts to 2024-01-01 [(F2a8b179L18R18)](https://github.com
  • Added support for the Premium SKU and its features:
    • private only Bastion (incl. a dedicated test case)
    • session recording
  • Added support for availability zones

Resolves #3308

Note: due to resource provider errors, the support for the Developer SKU is not included in this update

Pipeline Reference

Pipeline
avm.res.network.bastion-host

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@krbar krbar self-assigned this Oct 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Oct 22, 2024
@krbar krbar marked this pull request as ready for review October 22, 2024 22:01
@krbar krbar requested review from a team as code owners October 22, 2024 22:01
@krbar krbar added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Oct 22, 2024
@AlexanderSehr AlexanderSehr self-assigned this Oct 23, 2024
@AlexanderSehr AlexanderSehr self-requested a review October 23, 2024 09:29
@krbar krbar requested a review from AlexanderSehr October 25, 2024 08:37
@AlexanderSehr AlexanderSehr merged commit a14318a into main Oct 25, 2024
16 checks passed
@AlexanderSehr AlexanderSehr deleted the users/krbar/bastionUpdate branch October 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: bastionHosts module is not on the latest API version
2 participants