Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Kusto cluster system assigned managed identity #3048

Merged
merged 14 commits into from
Sep 7, 2024

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Aug 14, 2024

Description

Add managed identity capability to cluster.

Pipeline Reference

Pipeline
avm.res.kusto.cluster

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Aug 14, 2024
@oZakari oZakari marked this pull request as ready for review August 14, 2024 17:09
@oZakari oZakari requested review from a team as code owners August 14, 2024 17:09
@oZakari oZakari enabled auto-merge (squash) August 14, 2024 17:14
@oZakari oZakari force-pushed the kusto-cluster-ssid branch 2 times, most recently from d13b6d2 to f94ef5a Compare August 14, 2024 17:41
@oZakari oZakari changed the title feat: Kusto cluster ssid feat: Kusto cluster managed identity Aug 15, 2024
@oZakari oZakari changed the title feat: Kusto cluster managed identity feat: Kusto cluster sami Aug 15, 2024
@oZakari oZakari changed the title feat: Kusto cluster sami feat: Kusto cluster system assigned managed identity Aug 15, 2024
@oZakari oZakari disabled auto-merge August 15, 2024 19:06
@oZakari oZakari marked this pull request as draft August 15, 2024 19:06
@oZakari
Copy link
Contributor Author

oZakari commented Sep 5, 2024

Hey @segraef, I believe I've correctly added an output for the principal ID, but the test is still saying it doesn't exist. Could you take a quick glance when you get a chance please?

@oZakari oZakari marked this pull request as ready for review September 6, 2024 18:18
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Sep 6, 2024
@AlexanderSehr
Copy link
Contributor

Great work @oZakari and sorry for the issue with the expected vs documented value.

@AlexanderSehr AlexanderSehr merged commit 41da778 into Azure:main Sep 7, 2024
4 checks passed
@oZakari oZakari deleted the kusto-cluster-ssid branch September 8, 2024 22:24
jianingwang123 pushed a commit to jianingwang123/bicep-registry-modules that referenced this pull request Sep 12, 2024
## Description
Add managed identity capability to cluster.

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.kusto.cluster](https://github.com/oZakari/bicep-registry-modules/actions/workflows/avm.res.kusto.cluster.yml/badge.svg?branch=kusto-cluster-ssid)](https://github.com/oZakari/bicep-registry-modules/actions/workflows/avm.res.kusto.cluster.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [x] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

---------

Co-authored-by: Matt Hoffmeister <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Core Team 🧞 This item needs the AVM Core Team to review it Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants