Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added authorizations UDT to registration definition module #1776

Merged
merged 23 commits into from
Apr 30, 2024

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Apr 29, 2024

Description

  • Added User-defined type for authorizations
  • Removed location param
  • Updated tests
    • Adjusted to new interface
    • Removed unused dependencies
    • Altered max test to use optional parameters

Pipeline Reference

Pipeline
avm.res.managed-services.registration-definition

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

@AlexanderSehr AlexanderSehr added Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Class: Resource Module 📦 This is a resource module labels Apr 29, 2024
@AlexanderSehr AlexanderSehr self-assigned this Apr 29, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 29, 2024
@AlexanderSehr AlexanderSehr changed the title Users/alsehr/registration fix feat: Added authorizations parameter to registration definition module Apr 29, 2024
@AlexanderSehr AlexanderSehr removed the Needs: Triage 🔍 Maintainers need to triage still label Apr 29, 2024
@AlexanderSehr AlexanderSehr marked this pull request as ready for review April 29, 2024 19:36
@AlexanderSehr AlexanderSehr requested review from a team as code owners April 29, 2024 19:36
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) April 29, 2024 19:36
@AlexanderSehr AlexanderSehr changed the title feat: Added authorizations parameter to registration definition module feat: Added authorizations UDT to registration definition module Apr 29, 2024
@AlexanderSehr AlexanderSehr disabled auto-merge April 29, 2024 20:25
@AlexanderSehr AlexanderSehr merged commit 23a2d4c into main Apr 30, 2024
17 checks passed
@AlexanderSehr AlexanderSehr deleted the users/alsehr/registrationFix branch April 30, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants