feat: New module avm/ptn/network/hub-networking
#1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zure#1056) ## Description - Adding the isAcceleratedNetworkSupported - Changing default value of isAcceleratedNetworkSupported to true Closes Azure#1024 ## Pipeline Reference | Pipeline | | -------- | | [](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.compute.gallery.yml) | ## Type of Change - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings
…Azure#1057) ## Description Fixed passing telemetry to the private endpoints in four below modules. | Pipeline | | - | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.host-pool.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.workspace.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml) | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml) | ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [x] This is a bug fix: - [x] Someone has opened a bug report issue, and I have included "Closes #" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. - [x] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [x] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number.
## Description - Fixed Bicep warning regarding Managed Identity type: `Expected a value of type "'None' | 'SystemAssigned' | 'UserAssigned'" but the provided value is of type "'SystemAssigned' | 'UserAssigned' | null". bicep(BCP321)` | Pipeline | | - | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml) | ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [x] This is a bug fix: - [ ] Someone has opened a bug report issue, and I have included "Closes #" in the PR description. - [x] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. - [x] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [x] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number.
…re#1052) ## Description - fixing Block Blob Storage creation - added a test case testing Block Blob Storage creation Resolves Azure#1012 | Pipeline | | - | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml) | ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [x] This is a bug fix: - [x] Someone has opened a bug report issue, and I have included "Closes Azure#1012" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. - [x] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [x] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number.
## Description Add telemetry token replacement to publish from tag pipeline Tested by: 1. enforce publishing of a new tag 2. run the publish from tag pipeline on the new tag > Note: the publish from tag source code (e.g. `Publish-ModuleFromTagToPBR.ps1` script) is loaded from the codebase of the published tag. This means this new pipeline cannot be run for older module tags ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.platform.publish-tag.yml) (test from main, failure on the validation step as expected from a fork) | Ref to test run for token replacement logs https://github.com/eriqua/bicep-registry-modules/actions/runs/8048795026/job/21980879825#step:7:59 ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
## Description <!--Why this PR? What is changed? What is the effect? etc.--> Closes Azure/Azure-Verified-Modules#507 Closes Azure/ResourceModules#4415 ## Adding a new module <!--Run through the checklist if your PR adds a new module.--> - [x] A proposal has been submitted and approved. - [x] I have included "Closes #{module_proposal_issue_number}" in the PR description. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. ### Testing [](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.network.network-manager.yml) ### Teams   ### Important Notes⚠️ The following had to be changed to allow deployment of the module into the CI: - The WAF Tests scope was set to `securityAdmin` only unlike the MAX test. The Default test connectivity scope was set to `connectivity` only. This allows us to deploy multiple instances of AVNM targeting the same subscription scope. If we do not do that, the CI will fail. Hence WAF tests are currently only validating security admin. Max tests will contain all features.  - The Max test AVNM scope is set to `managementGroups`. This allows us to validate the service to on management groups. If we do not do that, we will miss out on testing out MG scope coverage for AVNM. The second issue will be similar to the one above, where we can only have ONE AVNM instance deployed to manage a particular scope. - I have updated a parameter `connectivityTopology` in the `connectivity-configuration` child module to call out `Mesh` being a preview feature as per the AVNM shared specs requirement. ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [ ] This is a bug fix: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [ ] I have run deployment tests locally to ensure the module is deployable. - [ ] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number. --------- Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Erika Gressi <[email protected]>
## Description - Fixed used Network-Manager token in test file ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | - | | [](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.network.network-manager.yml) | --------- Co-authored-by: Erika Gressi <[email protected]>
## Description Closes Azure/Azure-Verified-Modules#508 Closes Azure/ResourceModules#4412 ### Tests [](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.dev-test-lab.lab.yml) ### Teams   ### Important Changes from CARML ℹ️ The following has been changed as the module is migrated from CARML - Removal of `tags` for a child resource called `policyset/policy`. This tag resource cannot align to AVM specs for tags. . When attempting to align. I get errors from the API as a not supported method, when trying to pass the tag object as nullable. ```bicep @sys.description('Optional. Tags of the resource.') param tags object? ```  Tried setting the tag value on the resource to mitigate `tags: tags ?? {}` or `tags: !empty(tags) ? tags : {}` but without success. Hence I have removed it as I do not see value having it in the first place. The only way for this to work is for the param to be set as `param tags object = {}`. Any other ideas would be helpful. - Additionally, I have reduced the number of parameters for WAF aligned. ## Adding a new module <!--Run through the checklist if your PR adds a new module.--> - [x] A proposal has been submitted and approved. - [x] I have included "Closes #{module_proposal_issue_number}" in the PR description. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [ ] This is a bug fix: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [ ] I have run deployment tests locally to ensure the module is deployable. - [ ] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [ ] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number. --------- Co-authored-by: Alexander Sehr <[email protected]> Co-authored-by: Erika Gressi <[email protected]>
…1069) ## Description - Added missing value `'Basic'` to allowed values of the parameter `tier` Resolves Azure#1063 | Pipeline | | - | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.network.firewall-policy.yml) | ## Updating an existing module <!--Run through the checklist if your PR updates an existing module.--> - [x] This is a bug fix: - [x] Someone has opened a bug report issue, and I have included "Closes Azure#1063" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. - [x] I have read the [Updating an existing module](https://github.com/Azure/bicep-registry-modules/blob/main/CONTRIBUTING.md#updating-an-existing-module) section in the contributing guide and updated the `version.json` file properly: - [x] The PR contains backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`. - [ ] The PR contains backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] The PR contains breaking changes, and I have bumped the MAJOR version in `version.json`. - [ ] I have updated the examples in README with the latest module version number.
## Description Enforce vnet publish with source by bumping the patch version with a minor parameter description update ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.network.virtual-network.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [ ] I'm sure there are no other open Pull Requests for the same update/change - [ ] I have run `Set-AVMModule` locally to generate the supporting module files. - [ ] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep -->
…re#1054) ## Description The default or minimum parameter deployment was not working, and we had to default the Managed identity to "None" instead of null if a user does not supply a value for the parameter The workflow is only failing on the last step which is the publish step. It succeeds on every other step and creates the resource in azure <img width="1147" alt="image" src="https://github.com/Azure/bicep-registry-modules/assets/30802291/1e003ace-112f-43e4-ab4c-3b9b0d9a9ad9"> ## Pipeline Reference https://github.com/clintgrove/bicep-registry-modules/actions/runs/8002753877 [](https://github.com/clintgrove/bicep-registry-modules/actions/workflows/avm.res.databricks.access-connector.yml) ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [x] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to day with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Erika Gressi <[email protected]>
## Description - Adjusted token handling - Aligned local test file token replacement with workflow's - Small typo fix in deploy action > Note: Required me to register the `Microsoft.Network` provider at mgmt group scope ([ref](hashicorp/terraform-provider-azurerm#24528)) ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.network.network-manager.yml) | ## Type of Change <!-- Use the check-boxes [x] on the options that are relevant. --> - [x] Update to CI Environment or utlities (Non-module effecting changes) - [ ] Azure Verified Module updates: - [x] Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation
) ## Description Unorphaned `avm/res/db-for-postgre-sql/flexible-server` as @joaria became the owner of the module.
…#1055) ## Description New Module `avm/res/machine-learning-services/workspace`, migrated from CARML. ## Adding a new module <!--Run through the checklist if your PR adds a new module.--> - [x] A proposal has been submitted and approved. - [ ] I have included "Closes #{module_proposal_issue_number}" in the PR description. - [ ] I have run `brm validate` locally to verify the module files. - [x] I have run deployment tests locally to ensure the module is deployable. ## Pipeline references | Pipeline | | - | | [](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.machine-learning-services.workspace.yml) | --------- Co-authored-by: Alexander Sehr <[email protected]>
## Description
Remove issue templates not related to AVM to avoid confusion.
Existing templates can cover if required.
## Pipeline Reference
<!-- Insert your Pipeline Status Badge below -->
| Pipeline |
| -------- |
| N/A |
## Type of Change
<!-- Use the check-boxes [x] on the options that are relevant. -->
- [x] Update to CI Environment or utlities (Non-module effecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
- [ ] Update to documentation
## Checklist
- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings
<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
AlexanderSehr
approved these changes
Sep 13, 2024
](https://github.com/ReneHezser/bicep-registry-modules/actions/workflows/avm.res.compute.gallery.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.host-pool.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.desktop-virtualization.workspace.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.insights.private-link-scope.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.operational-insights.workspace.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.storage.storage-account.yml){kind=link}
](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.platform.publish-tag.yml){kind=link}
](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.network.network-manager.yml){kind=link}
](https://github.com/AlexanderSehr/bicep-registry-modules/actions/workflows/avm.res.network.network-manager.yml){kind=link}
](https://github.com/ahmadabdalla/bicep-registry-modules/actions/workflows/avm.res.dev-test-lab.lab.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.network.firewall-policy.yml){kind=link}
](https://github.com/eriqua/bicep-registry-modules/actions/workflows/avm.res.network.virtual-network.yml){kind=link}
](https://github.com/clintgrove/bicep-registry-modules/actions/workflows/avm.res.databricks.access-connector.yml){kind=link}
](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.network.network-manager.yml){kind=link}
](https://github.com/krbar/bicep-registry-modules/actions/workflows/avm.res.machine-learning-services.workspace.yml){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New pattern module for hub networking.
Pipeline Reference
Type of Change
Adding a new module
Checklist
Set-AVMModulelocally to generate the supporting module files.