Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update Web App Server Farm Module #1251

Merged
merged 4 commits into from
Mar 12, 2024
Merged

fix: Update Web App Server Farm Module #1251

merged 4 commits into from
Mar 12, 2024

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented Mar 12, 2024

Description

Pipeline
avm.res.web.serverfarm

image

Type of Change

  • Update to CI Environment or utlities (Non-module effecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

@jtracey93 jtracey93 requested review from a team as code owners March 12, 2024 08:22
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Mar 12, 2024
@jtracey93 jtracey93 changed the title Update main.bicep web app Update Web App Server Farm Module Mar 12, 2024
@jtracey93 jtracey93 changed the title Update Web App Server Farm Module fix: Update Web App Server Farm Module Mar 12, 2024
@ChrisSidebotham
Copy link
Contributor

@jtracey93 - Can you run the set-AvmModule utility to update the corresponding JSON please :D

@ChrisSidebotham ChrisSidebotham added Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Mar 12, 2024
@jtracey93
Copy link
Contributor Author

@jtracey93 - Can you run the set-AvmModule utility to update the corresponding JSON please :D

done

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Reply has been added to issue, maintainer to review and removed Needs: Author Feedback 👂 Awaiting feedback from the issue/PR author labels Mar 12, 2024
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@jtracey93 jtracey93 merged commit 0f9eba4 into main Mar 12, 2024
17 checks passed
@jtracey93 jtracey93 deleted the jtracey93-patch-1 branch March 12, 2024 09:44
hundredacres pushed a commit to hundredacres/bicep-registry-modules that referenced this pull request Mar 12, 2024
## Description

<!--
Update RBAC Role List to allow publish of a new version for MVP summit
demos.

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.res.web.serverfarm](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.web.serverfarm.yml/badge.svg?branch=jtracey93-patch-1)](https://github.com/Azure/bicep-registry-modules/actions/workflows/avm.res.web.serverfarm.yml)
|


![image](https://github.com/Azure/bicep-registry-modules/assets/41163455/6ba46c12-2eb9-44bb-9cdb-c2de96189e26)


## Type of Change

<!-- Use the check-boxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utlities (Non-module effecting
changes)
- [x] Azure Verified Module updates:
- [x] Bugfix containing backwards compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [x] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [ ] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [ ] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to day with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Attention 👋 Reply has been added to issue, maintainer to review Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants