Skip to content

Commit

Permalink
feat: CI - Added items to removal order to make it more seemless & ro…
Browse files Browse the repository at this point in the history
…bust (#4355)

## Description

The changes are done for 2 modules
- `Microsoft.Network/virtual-network-gateway`
- `Microsoft.Network/virtual-hub`

## Pipeline Reference

- `Microsoft.Network/virtual-network-gateway`
- [Example run before
change](https://github.com/Azure/bicep-registry-modules/actions/runs/13056545937/job/36429080193#step:4:876)
- [Example run after
change](https://github.com/Azure/bicep-registry-modules/actions/runs/13058074724/job/36438664464#step:4:1027)
- `Microsoft.Network/virtual-hub`
- [Example run before
change](https://github.com/Azure/bicep-registry-modules/actions/runs/13049383159/job/36427686075#step:4:1055)
- [Example run after
change](https://github.com/Azure/bicep-registry-modules/actions/runs/13058146827/job/36434368330#step:4:1062)

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [x] Update to CI Environment or utilities (Non-module affecting
changes)
- [ ] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation
  • Loading branch information
AlexanderSehr authored Feb 2, 2025
1 parent 55993f1 commit f323e8f
Showing 1 changed file with 4 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ function Initialize-DeploymentRemoval {
'Microsoft.Insights/diagnosticSettings',
'Microsoft.Network/privateEndpoints/privateDnsZoneGroups',
'Microsoft.Network/privateEndpoints',
'Microsoft.Network/azureFirewalls',
'Microsoft.Network/virtualHubs/routingIntent', # Must be deleted before e.g., an Azure Firewall that it is referencing
'Microsoft.Network/azureFirewalls', # Must be deleted before e.g., a Virtual Hub that it is using.
'Microsoft.Network/virtualHubs',
'Microsoft.Network/virtualWans',
'Microsoft.OperationsManagement/solutions',
Expand All @@ -101,6 +102,8 @@ function Initialize-DeploymentRemoval {
'Microsoft.NetApp/netAppAccounts/backupVaults', # Must be deleted before netapp account because the Resource Provider does not allow deleting the account as long as it has nested resources
'Microsoft.NetApp/netAppAccounts/snapshotPolicies', # Must be deleted before netapp account because the Resource Provider does not allow deleting the account as long as it has nested resources
'Microsoft.NetApp/netAppAccounts/capacityPools', # Must be deleted before netapp account because the Resource Provider does not allow deleting the account as long as it has nested resources
'Microsoft.Network/virtualNetworkGateways', # Must be deleted before the Public IP that is associated with it
'Microsoft.Network/loadBalancers', # Must be deleted before e.g. a GatewaySubnet that is associated with it
'Microsoft.Resources/resourceGroups'
)

Expand Down

0 comments on commit f323e8f

Please sign in to comment.