Skip to content

Commit

Permalink
fix: Change the naming policy, to use subscription id unique string, …
Browse files Browse the repository at this point in the history
…for dns uniqueness of keyvault, (#4202)

## Description
Fix for resolving the dns conflict for keyvault issue.

<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes #123
Fixes #456
Closes #123
Closes #456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.aca-lza.hosting-environment](https://github.com/kpantos/bicep-registry-modules/actions/workflows/avm.ptn.aca-lza.hosting-environment.yml/badge.svg)](https://github.com/kpantos/bicep-registry-modules/actions/workflows/avm.ptn.aca-lza.hosting-environment.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [X] Azure Verified Module updates:
- [X] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [X] I'm sure there are no other open Pull Requests for the same
update/change
- [X] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [X] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->
  • Loading branch information
kpantos authored Jan 17, 2025
1 parent fe64ece commit 9d2f72a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion avm/ptn/aca-lza/hosting-environment/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ param enableDdosProtection bool = false
module naming 'modules/naming/naming.module.bicep' = {
name: take('deploy-naming-${deployment().name}', 64)
params: {
uniqueId: uniqueString(workloadName)
uniqueId: uniqueString(subscription().id, location, environment, workloadName)
spokeResourceGroupName: spokeResourceGroupName
environment: environment
workloadName: workloadName
Expand Down
4 changes: 2 additions & 2 deletions avm/ptn/aca-lza/hosting-environment/main.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"_generator": {
"name": "bicep",
"version": "0.32.4.45862",
"templateHash": "7424977067105298324"
"templateHash": "2541695628448359364"
},
"name": "Container Apps Landing Zone Accelerator",
"description": "This Azure Container Apps pattern module represents an Azure Container Apps deployment aligned with the cloud adoption framework",
Expand Down Expand Up @@ -270,7 +270,7 @@
"mode": "Incremental",
"parameters": {
"uniqueId": {
"value": "[uniqueString(parameters('workloadName'))]"
"value": "[uniqueString(subscription().id, parameters('location'), parameters('environment'), parameters('workloadName'))]"
},
"spokeResourceGroupName": {
"value": "[parameters('spokeResourceGroupName')]"
Expand Down

0 comments on commit 9d2f72a

Please sign in to comment.