-
Notifications
You must be signed in to change notification settings - Fork 409
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: module
avm/res/network/nat-gateway (#3341)
## Description added a test case about the use of an existing Public IP address Closes #2378 ## Pipeline Reference [](https://github.com/fabmas/bicep-registry-modules/actions/workflows/avm.res.network.nat-gateway.yml) | Pipeline | | -------- | | | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [x] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [x] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
- Loading branch information
](https://github.com/fabmas/bicep-registry-modules/actions/workflows/avm.res.network.nat-gateway.yml){kind=link}
Showing
5 changed files
with
163 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
avm/res/network/nat-gateway/tests/e2e/existingPip/dependencies.bicep
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| @description('Optional. The location to deploy to.') | ||
| param location string = resourceGroup().location | ||
|
|
||
| @description('Required. The name of the Public IP to create.') | ||
| param existingPipName string | ||
|
|
||
| resource existingPip 'Microsoft.Network/publicIPAddresses@2023-04-01' = { | ||
| name: existingPipName | ||
| location: location | ||
| sku: { | ||
| name: 'Standard' | ||
| tier: 'Regional' | ||
| } | ||
| properties: { | ||
| publicIPAllocationMethod: 'Static' | ||
| } | ||
| zones: [ | ||
| '1' | ||
| '2' | ||
| '3' | ||
| ] | ||
| } | ||
|
|
||
| @description('The resource ID of the existing Public IP.') | ||
| output existingPipResourceId string = existingPip.id |
61 changes: 61 additions & 0 deletions
61
avm/res/network/nat-gateway/tests/e2e/existingPip/main.test.bicep
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| targetScope = 'subscription' | ||
|
|
||
| metadata name = 'Using an existing Public IP' | ||
| metadata description = 'This instance deploys the module using an existing Public IP address.' | ||
|
|
||
| // ========== // | ||
| // Parameters // | ||
| // ========== // | ||
|
|
||
| @description('Optional. The name of the resource group to deploy for testing purposes.') | ||
| @maxLength(90) | ||
| param resourceGroupName string = 'dep-${namePrefix}-network.natgateway-${serviceShort}-rg' | ||
|
|
||
| @description('Optional. The location to deploy resources to.') | ||
| param resourceLocation string = deployment().location | ||
|
|
||
| @description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.') | ||
| param serviceShort string = 'nngepip' | ||
|
|
||
| @description('Optional. A token to inject into the name of each resource.') | ||
| param namePrefix string = '#_namePrefix_#' | ||
|
|
||
| // ============ // | ||
| // Dependencies // | ||
| // ============ // | ||
|
|
||
| // General resources | ||
| // ================= | ||
| resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = { | ||
| name: resourceGroupName | ||
| location: resourceLocation | ||
| } | ||
|
|
||
| module nestedDependencies 'dependencies.bicep' = { | ||
| scope: resourceGroup | ||
| name: '${uniqueString(deployment().name, resourceLocation)}-nestedDependencies' | ||
| params: { | ||
| location: resourceLocation | ||
| existingPipName: '${namePrefix}${serviceShort}001-existingpip1' | ||
|
|
||
| } | ||
| } | ||
|
|
||
|
|
||
| // ============== // | ||
| // Test Execution // | ||
| // ============== // | ||
|
|
||
| @batchSize(1) | ||
| module testDeployment '../../../main.bicep' = [ | ||
| for iteration in ['init', 'idem']: { | ||
| scope: resourceGroup | ||
| name: '${uniqueString(deployment().name, resourceLocation)}-test-${serviceShort}-${iteration}' | ||
| params: { | ||
| location: resourceLocation | ||
| name: '${namePrefix}${serviceShort}001' | ||
| zone: 1 | ||
| publicIpResourceIds: [nestedDependencies.outputs.existingPipResourceId] | ||
| } | ||
| } | ||
| ] |