-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Microsoft.Resources/deployments stable API version 2025-03-01 #32822
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API change check APIView has identified API level changes in this PR and created following API reviews. |
5c224c8
to
25a8935
Compare
@ramoka178 or next ARM reviewer, I requested some guidance on how to resolve this via the API spec review channel (https://teams.microsoft.com/l/message/19:[email protected]/1742917076477?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1742917076477&teamName=Azure%20SDK&channelName=API%20Spec%20Review&createdTime=1742917076477) and @mikeharder said that I should request the If this error cannot be excepted, I'm not certain how to resolve it. There's a bunch of other resource types I have no familiarity with, and I do not understand what side effects some config changes have. I made some changes to the README.md, including deleting multiple tag declarations for |
Adding Approved-Avocado for this one PR is OK, but going forward you will need to change your readme.md (assuming the Avocado rule is correct).
Do you know who owns the other resource types? Is there an owner for the readme.md as a whole, that includes all the resource types? Our first question is "why do you need multiple default tags like this?". |
No. My team owns resource types deployments, deploymentStacks, deploymentScripts, bicepClient, templateSpecs. We don't own subscriptions, changes, dataBoundaries, links, or snapshots. So it's a mix of owners which makes this a little more difficult.
I don't know. It seems like all the |
Is there someone else on your team responsible for the readme as a whole? Should we work on this with just you, or others on your team? |
There's no official owner but @anthony-c-martin said he can fill for one. |
@msyyc It looks like merging is blocked until you approve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve for Python SDK part.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.