Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribute to v4 custom model-cmdlets #27468

Merged
merged 4 commits into from
Apr 3, 2025

Conversation

Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Mar 28, 2025

Description

Add attribute to custom model cmdlets and regenerate modules by latest generator to solve autorest generator breaking change indroduced here.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi Pan-Qi force-pushed the bernard-add-model-cmdlet-attribute branch from 6b63694 to f6df14d Compare April 1, 2025 08:09
@@ -0,0 +1,26 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file?

Copy link
Contributor Author

@Pan-Qi Pan-Qi Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK, it's auto generated, any problem?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what Yabo means are the two files ServiceBus.Autorest/11 and ServiceBus.Autorest/13.

@Pan-Qi Pan-Qi marked this pull request as ready for review April 1, 2025 10:33
@@ -0,0 +1,26 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what Yabo means are the two files ServiceBus.Autorest/11 and ServiceBus.Autorest/13.

@dolauli dolauli self-assigned this Apr 2, 2025
@Pan-Qi Pan-Qi requested a review from dolauli April 3, 2025 00:01
@dolauli dolauli merged commit ce59d26 into main Apr 3, 2025
12 checks passed
@dolauli dolauli deleted the bernard-add-model-cmdlet-attribute branch April 3, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants