-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Az.AddomainService] ADDomainServices update generation tool version: autorest.powershell … #27451
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
… jinpei/main/addomainservices-v4
tools/CreateMappings_rules.json
Outdated
@@ -968,4 +968,8 @@ | |||
"module": "Pinecone", | |||
"alias": "Pinecone" | |||
}, | |||
{ | |||
"module": "ADDomainServices", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this change for?
@@ -18,6 +18,9 @@ | |||
- Additional information about change #1 | |||
--> | |||
## Upcoming Release | |||
* Az.ADDomainServices module is migrated to Autorest PowerShell v4: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use our unified change log as we discussed. Please also update the other PRs accordingly.
@@ -73,7 +64,7 @@ directive: | |||
"description": "HTTP 200 (OK) should be returned if the object exists and was deleted successfully." | |||
} | |||
- where: | |||
variant: ^Create$|^CreateViaIdentity$|^CreateViaIdentityExpanded$|^Update$|^UpdateViaIdentity$ | |||
variant: ^(Create|Update)(?!.*?(Expanded|JsonFilePath|JsonString)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the migration guide to remove variant: ^CreateViaIdentity$|^CreateViaIdentityExpanded$
…v3->v4
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.