Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Az.DataProtection] Added support for validate for Modify backup with UAMI #27445

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

hiaga
Copy link
Member

@hiaga hiaga commented Mar 25, 2025

Description

Added support for validate for Modify backup as Test-AzDataProtectionBackupInstanceUpdate cmdlet

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@dolauli
Copy link
Contributor

dolauli commented Mar 28, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Contributor

@dolauli dolauli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the change log accordingly and fixed the CI failures.

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@hiaga
Copy link
Member Author

hiaga commented Mar 28, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27445 in repo Azure/azure-powershell

@dolauli
Copy link
Contributor

dolauli commented Mar 31, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@hiaga
Copy link
Member Author

hiaga commented Apr 7, 2025

@dolauli Tests pass on running in playback mode in local setup. is there an issue with CI run ?

@dolauli
Copy link
Contributor

dolauli commented Apr 8, 2025

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants