Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NetAppFiles] Change to api-version 2024-09-01 #27360

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

audunn
Copy link
Member

@audunn audunn commented Mar 17, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@notyashhh
Copy link
Member

/azp run

1 similar comment
@audunn
Copy link
Member Author

audunn commented Mar 18, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Mar 18, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh notyashhh self-assigned this Mar 19, 2025
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@audunn
Copy link
Member Author

audunn commented Mar 19, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

@audunn
Copy link
Member Author

audunn commented Mar 20, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

@vidai-msft
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Mar 20, 2025

When approved is it possible to relase asap? This contains feature that has been announced but was missing from the PowerShell module?

@audunn
Copy link
Member Author

audunn commented Mar 27, 2025

/azp run

@audunn
Copy link
Member Author

audunn commented Mar 31, 2025

Tests failing in the pipline not locally, Any ideas?

System.Management.Automation.CommandNotFoundException : The term 'Get-AzKeyVault' is not recognized as a name of a cmdlet, function, script file, or executable program.

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@notyashhh
Copy link
Member

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Collaborator

hi @audunn , please re-record 'Test-AccountCMK', it was not correctly recorded before because az.keyvault was not set up properly

@audunn
Copy link
Member Author

audunn commented Apr 4, 2025

hi @audunn , please re-record 'Test-AccountCMK', it was not correctly recorded before because az.keyvault was not set up properly
@VeryEarly Looks like it is failing to load the nested extension Az.KeyVault.Extension, the Az.KeyVault.Extension module is there in the artifacts directory in a folder

  Message: 
System.Management.Automation.RuntimeException : Test failed due to a non-empty error stream. First error: PowerShell Error Record: The module to process './Az.KeyVault.Extension', listed in field 'NestedModules' of module manifest 'C:\Users\****\source\repos\azure\azure-powershell\artifacts\Debug\Az.KeyVault\Az.KeyVault.psd1' was not processed because no valid module was found in any module directory.
Exception:System.Management.Automation.PSInvalidOperationException: The module to process './Az.KeyVault.Extension', listed in field 'NestedModules' of module manifest 'C:\Users\*****\source\repos\azure\azure-powershell\artifacts\Debug\Az.KeyVault\Az.KeyVault.psd1' was not processed because no valid module was found in any module directory.
 ---> System.IO.FileNotFoundException: The module to process './Az.KeyVault.Extension', listed in field 'NestedModules' of module manifest 'C:\Users\*****\source\repos\azure\azure-powershell\artifacts\Debug\Az.KeyVault\Az.KeyVault.psd1' was not processed because no valid module was found in any module directory.
   --- End of inner exception stack trace ---
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModuleManifest(String moduleManifestPath, ExternalScriptInfo manifestScriptInfo, Hashtable data, Hashtable localizedData, ManifestProcessingFlags manifestProcessingFlags, Version minimumVersion, Version maximumVersion, Version requiredVersion, Nullable`1 requiredModuleGuid, ImportModuleOptions& options, Boolean& containedErrors)
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModuleManifest(ExternalScriptInfo scriptInfo, ManifestProcessingFlags manifestProcessingFlags, Version minimumVersion, Version maximumVersion, Version requiredVersion, Nullable`1 requiredModuleGuid, ImportModuleOptions& options)
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModule(PSModuleInfo parentModule, String fileName, String moduleBase, String prefix, SessionState ss, Object privateData, ImportModuleOptions& options, ManifestProcessingFlags manifestProcessingFlags, Boolean& found, Boolean& moduleFileFound)
   at Microsoft.PowerShell.Commands.ModuleCmdletBase.LoadModule(String fileName, String moduleBase, String prefix, SessionState ss, ImportModuleOptions& options, ManifestProcessingFlags manifestProcessingFlags, Boolean& found)
   at Microsoft.PowerShell.Commands.ImportModuleCommand.ImportModule_LocallyViaName(ImportModuleOptions importModuleOptions, String name)

@VeryEarly
Copy link
Collaborator

it looks like dependency in your local was not built properly.

Please try below and record test again:

.\tools\buildScripts\buildModules.ps1 -TargetModule NetAppFiles

@NoriZC
Copy link
Contributor

NoriZC commented Apr 7, 2025

/azp run

1 similar comment
@VeryEarly
Copy link
Collaborator

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

1 similar comment
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@audunn
Copy link
Member Author

audunn commented Apr 7, 2025

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27360 in repo Azure/azure-powershell

@audunn
Copy link
Member Author

audunn commented Apr 7, 2025

@VeryEarly for some reason this did not work in the first go but did after re-trying and re-building. I cannot run pipeline can you run it to verify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants