Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to CosmosDB RP API Version 2024-09-01-preview #26110

Open
wants to merge 9 commits into
base: Az.CosmosDB-preview
Choose a base branch
from

Conversation

carjackson-msft
Copy link
Member

@carjackson-msft carjackson-msft commented Sep 16, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Sep 16, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Signature Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 79.44 % 85.63% Test coverage cannot be lower than the number of the last release.
❌ - MacOS
⚠️PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 79.44% 85.63% Test coverage cannot be lower than the number of the last release.
⚠️Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description
⚠️ Test Coverage Less Than 80% 79.44% 85.63% Test coverage cannot be lower than the number of the last release.
️✔️Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@carjackson-msft carjackson-msft changed the title [DRAFT] Update SDK to CosmosDB RP API Version 2024-09-01-preview Update SDK to CosmosDB RP API Version 2024-09-01-preview Sep 30, 2024
@carjackson-msft carjackson-msft marked this pull request as ready for review September 30, 2024 22:58
@carjackson-msft
Copy link
Member Author

Hi @VeryEarly, could you please assist in reviewing?

@Nickcandy
Copy link
Contributor

@carjackson-msft Hi, please add your changelog

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@pjohari-ms
Copy link
Member

@Nickcandy @VeryEarly Added the changelog. Please take a look and merge.

@pjohari-ms
Copy link
Member

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 26110 in repo Azure/azure-powershell

@Nickcandy
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@Nickcandy
Copy link
Contributor

Accoading to the ci pipelines, your tests failed in MacOS env. Could you find the root cause? https://dev.azure.com/azclitools/public/_build/results?buildId=199405&view=logs&j=e44bd064-d8d9-5feb-6343-09b8c49ab1a8&t=85a1ad8e-4daf-5689-e663-871501e587ee

@Nickcandy
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@Nickcandy
Copy link
Contributor

Hi @pjohari-ms , we have several changes to fix our CI pipelines. But there are several conflicts when I try to merge it. #26464
Could you raise a pr to merge main branch to Az.CosmosDB-preview?

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants