Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy to Azure buttons to use URLs to raw files in GitHub #529

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

judyer28
Copy link
Collaborator

@judyer28 judyer28 commented Feb 11, 2025

Overview/Summary

Deploy to Azure buttons in the Resources section will now use URLs to the raw files in GitHub. This avoids issues with Azure downloading the template files. For example, "There was an error downloading the template ... Ensure that the template is publicly accessible and that the publisher has enabled CORS policy on the endpoint."

This PR fixes/adds/changes/removes

  1. Replace me
  2. Replace me
  3. Replace me

Breaking Changes

  1. Replace me
  2. Replace me

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@judyer28 judyer28 requested a review from a team as a code owner February 11, 2025 22:13
@judyer28 judyer28 requested review from kirtpatelmsft and removed request for a team February 11, 2025 22:14
Copy link
Contributor

@kirtpatelmsft kirtpatelmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyer28 judyer28 merged commit 48b38c4 into Azure:main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants