Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alert log templates for ARM and Bicep #527

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Fix alert log templates for ARM and Bicep #527

merged 4 commits into from
Feb 11, 2025

Conversation

judyer28
Copy link
Collaborator

@judyer28 judyer28 commented Feb 11, 2025 •
edited
Loading

Overview/Summary

Fixes ARM template checks that were failing. Sets autoMitigate to default true and removes muteActionDuration from log alert templates.

This PR fixes/adds/changes/removes

  1. Fix AMR template checks that were failing for log alerts
  2. Replace me
  3. Replace me

Breaking Changes

  1. Replace me
  2. Replace me

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@judyer28 judyer28 requested a review from a team as a code owner February 11, 2025 19:00
@judyer28 judyer28 requested review from kirtpatelmsft and removed request for a team February 11, 2025 19:14
kirtpatelmsft
kirtpatelmsft approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@kirtpatelmsft kirtpatelmsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyer28 judyer28 merged commit d532708 into Azure:main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirtpatelmsft kirtpatelmsft kirtpatelmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@judyer28 @kirtpatelmsft