Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syntax errors in yml files #506

Merged
merged 3 commits into from
Jan 27, 2025
Merged

syntax errors in yml files #506

merged 3 commits into from
Jan 27, 2025

Conversation

jfaurskov
Copy link
Contributor

Overview/Summary

Updates relevant yml files to remove syntax check errors. Described in https://dev.azure.com/CSUSolEng/Guidance%20-%20Observability/_workitems/edit/38484/

This PR fixes/adds/changes/removes

  1. .github/yml-schemas/validate_yml.py is updated to handle situations where alerts.yaml is empty.
  2. services/Batch/batchAccounts/alerts.yaml is updated with correct format tags
  3. services/Compute/virtualMachines/alerts.yaml tags are removed since they are empty
  4. services/Network/expressRouteCircuits/alerts.yaml is updated with relevant values where null as well as corrected indentation.
  5. services/Network/vpnGateways/alerts.yaml is updated with references
  6. Add services/Search/searchServices/Deploy-ActivityLog-SearchService-Del.json as it is missing
  7. Add missing properties to services/Search/searchServices/alerts.yaml

Breaking Changes

N/A

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@jfaurskov jfaurskov requested review from a team as code owners January 27, 2025 09:34
@jfaurskov jfaurskov requested a review from judyer28 January 27, 2025 09:35
@jfaurskov jfaurskov marked this pull request as draft January 27, 2025 09:43
judyer28
judyer28 previously approved these changes Jan 27, 2025
Copy link
Collaborator

@judyer28 judyer28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfaurskov jfaurskov marked this pull request as ready for review January 27, 2025 14:07
Copy link
Collaborator

@judyer28 judyer28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyer28 judyer28 merged commit 7281b53 into Azure:main Jan 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants