Merge pull request #503 from feliasson/main

Fixes bug in `dimensions` property for metric & log alerts generation for Bicep templates
Azure · Feb 11, 2025 · 4b9ef51 · 4b9ef51
2 parents 4617cb9 + c2b95f6
commit 4b9ef51
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/tooling/generate-templates/generate-templates.py b/tooling/generate-templates/generate-templates.py
@@ -263,7 +263,7 @@ def main():
               values: [{",".join(values)}]
             }}""")
 
-            bicep_template = bicep_template.replace("##DIMENSIONS##", "".join(dimensions))
+            bicep_template = bicep_template.replace("##DIMENSIONS##", "[" + "".join(dimensions) + "]")
           else:
             arm_template = arm_template.replace("##DIMENSIONS##", "[]")
             bicep_template = bicep_template.replace("##DIMENSIONS##", "[]")

diff --git a/tooling/generate-templates/templates/bicep/log.bicep b/tooling/generate-templates/templates/bicep/log.bicep
@@ -148,7 +148,7 @@ resource alert 'Microsoft.Insights/scheduledQueryRules@2021-08-01' = {
           query: query
           metricMeasureColumn: metricMeasureColumn
           resourceIdColumn: resourceIdColumn
-          dimensions: [##DIMENSIONS##]
+          dimensions: ##DIMENSIONS##
           operator: operator
           threshold: threshold
           timeAggregation: timeAggregation

diff --git a/tooling/generate-templates/templates/bicep/metric-dynamic.bicep b/tooling/generate-templates/templates/bicep/metric-dynamic.bicep
@@ -112,7 +112,7 @@ resource metricAlert 'Microsoft.Insights/metricAlerts@2018-03-01' = {
           criterionType: 'DynamicThresholdCriterion'
           name: '1st criterion'
           metricName: '##METRIC_NAME##'
-          dimensions: [##DIMENSIONS##]
+          dimensions: ##DIMENSIONS##
           operator: operator
           alertSensitivity: alertSensitivity
           failingPeriods: {

diff --git a/tooling/generate-templates/templates/bicep/metric-static.bicep b/tooling/generate-templates/templates/bicep/metric-static.bicep
@@ -106,7 +106,7 @@ resource metricAlert 'Microsoft.Insights/metricAlerts@2018-03-01' = {
         {
           name: '1st criterion'
           metricName: '##METRIC_NAME##'
-          dimensions: [##DIMENSIONS##]
+          dimensions: ##DIMENSIONS##
           operator: operator
           threshold: threshold
           timeAggregation: timeAggregation