-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RabbitMQ connection not closing #158
base: dev
Are you sure you want to change the base?
Conversation
Good day, any chance we can get this approved? Let me know if you need more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
If this extension is to follow some day the best practice on how to use RabbitMQ.Client (Still waiting for an answer #96), we may have multiple IRabbitMQModel (at least one for consuming and one for publishing, and maybe one for monitor) so closing connection inside RabbittMQModel is not ideal I think.
IMHO: the connection should be reused accross various functions using the same connection string and it should be initialized once and closed when the function stop and we should not need this.
Any idea when this is being merged? |
Added comment to associate issue #157. Awaiting response. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment. |
Please see comment in #157. I still think this is a valid pull request |
Any word on this issue? |
Reopening the pull request so it stays visible. I had planned to get the issue reproduced, but haven't gotten much time out of other work. |
Requesting to not spend time in editing the PR to work with the restructured files unless I or someone verifies the issue and confirms here. |
bump on closing this? |
This pull request fixes issue #157