Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RabbitMQ connection not closing #158

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: RabbitMQ connection not closing #158

wants to merge 1 commit into from

Conversation

Icidis
Copy link

@Icidis Icidis commented Mar 15, 2021

This pull request fixes issue #157

@ghost
Copy link

ghost commented Mar 15, 2021

CLA assistant check
All CLA requirements met.

@Icidis
Copy link
Author

Icidis commented Apr 15, 2021

Good day, any chance we can get this approved? Let me know if you need more information.

Copy link
Contributor

@Socolin Socolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

If this extension is to follow some day the best practice on how to use RabbitMQ.Client (Still waiting for an answer #96), we may have multiple IRabbitMQModel (at least one for consuming and one for publishing, and maybe one for monitor) so closing connection inside RabbittMQModel is not ideal I think.

IMHO: the connection should be reused accross various functions using the same connection string and it should be initialized once and closed when the function stop and we should not need this.

@grimmersnee
Copy link

Any idea when this is being merged?

@JatinSanghvi
Copy link
Contributor

Added comment to associate issue #157. Awaiting response.

@JatinSanghvi JatinSanghvi linked an issue Feb 1, 2022 that may be closed by this pull request
@ghost ghost added the no recent activity label Feb 8, 2022
@ghost
Copy link

ghost commented Feb 8, 2022

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

@ghost ghost closed this Feb 15, 2022
@Icidis
Copy link
Author

Icidis commented Feb 16, 2022

Please see comment in #157. I still think this is a valid pull request

@grimmersnee
Copy link

Any word on this issue?

@JatinSanghvi
Copy link
Contributor

Reopening the pull request so it stays visible. I had planned to get the issue reproduced, but haven't gotten much time out of other work.

@JatinSanghvi JatinSanghvi reopened this Mar 18, 2022
@JatinSanghvi
Copy link
Contributor

JatinSanghvi commented Mar 18, 2022

Requesting to not spend time in editing the PR to work with the restructured files unless I or someone verifies the issue and confirms here.

@steveb85
Copy link

bump on closing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RabbitMQ connections not closing
5 participants