Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configurable options and fixed ack logic #114

Merged
merged 7 commits into from
Nov 18, 2020

Conversation

yojagad
Copy link
Contributor

@yojagad yojagad commented Nov 12, 2020

Fixes #99 , #98.

cc: @cachai2

Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments. Thanks.

@yojagad
Copy link
Contributor Author

yojagad commented Nov 18, 2020

Upon further testing, realized that setting prefetchSize to anything other than 0 doesn't seem to work . Encountered the below error :
image
It could be a bug in the rabbitMQ dotnet client or some other rabbitMQ nuget it's referring as I noticed various other threads complaining about this. Upgraded client to 5.2.0 as well and still encountered the same.

I'll probably remove the option to make prefetchSize configurable.

@yojagad yojagad force-pushed the yojagad/ConfigurablePrefetch branch from 9dd1315 to 61e2a18 Compare November 18, 2020 02:22
Copy link
Member

@pragnagopa pragnagopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@yojagad yojagad merged commit 09c079a into dev Nov 18, 2020
@yojagad yojagad deleted the yojagad/ConfigurablePrefetch branch November 18, 2020 18:30
@freddymk87
Copy link

Hello @yojagad I am using the RabbitMQ binding ,with Azure Functions, c#.

I want to set the prefetch count to 1000 how can I ? should it be in the Startup function ?

@yojagad
Copy link
Contributor Author

yojagad commented Dec 1, 2020

Hello @freddymk87 . The prefetch count is something you should set within host.json. For rabbitMQ with custom prefetch count, the host.json should look like below.

{
    "version": "2.0",
    "extensions": {
        "rabbitMq": {
            "prefetchCount": 1000
         }
    }
}

Please ensure you use 1.0.0-beta version of the extension for the above to work.

@freddymk87
Copy link

freddymk87 commented Dec 1, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configurable concurrency similar to Azure Service Bus
4 participants