-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java support #111
Java support #111
Conversation
Thanks! Would be good to get @pragnagopa 's feedback here, as I know this differs from the initial proposed implementation |
@jeffhollan / @fabiocav - I recommend following similar approach as signalr and create Java annotations in this repo. This allows keeping annotations and c# attributes in sync and can be released independently of azure-function-java-library |
04fe338
to
d810c84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor comments
- Open issue to add integration test that verifies function.json generated by mvn
- Update PR description with same java function that uses this annotation. Later can be re-used in the documentation
...ary/java/src/main/java/com/microsoft/azure/functions/rabbitmq/annotation/RabbitMQOutput.java
Show resolved
Hide resolved
...ry/java/src/main/java/com/microsoft/azure/functions/rabbitmq/annotation/RabbitMQTrigger.java
Show resolved
Hide resolved
...va/src/test/java/com/microsoft/azure/functions/rabbitmq/annotation/RabbitMQTriggerTests.java
Outdated
Show resolved
Hide resolved
@pragnagopa Added issue here #112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few more nits . Thanks
...ary/java/src/main/java/com/microsoft/azure/functions/rabbitmq/annotation/RabbitMQOutput.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved. Nit, fix format before merging.
Part of work for #60
@jeffhollan / @fabiocav Following the signalr way of adding annotations for an extension (https://github.com/Azure/azure-functions-signalrservice-extension/tree/master/binding-library/java)
cc: @cachai2
Below is an example java function