-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Service] Fix: #29512: az webapp config backup update
: Fix 'str' object has no attribute 'name'
#30986
Open
seligj95
wants to merge
4
commits into
Azure:dev
Choose a base branch
from
seligj95:29512
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
webapp config backup create | cmd webapp config backup create update parameter webapp_name : updated property options from ['--webapp-name'] to ['--webapp-name', '-n'] |
||
webapp config backup delete | cmd webapp config backup delete update parameter webapp_name : updated property options from ['--webapp-name'] to ['--webapp-name', '-n'] |
||
webapp config backup list | cmd webapp config backup list update parameter webapp_name : updated property options from ['--webapp-name'] to ['--webapp-name', '-n'] |
||
webapp config backup restore | cmd webapp config backup restore update parameter webapp_name : updated property options from ['--webapp-name'] to ['--webapp-name', '-n'] |
||
webapp config backup show | cmd webapp config backup show update parameter webapp_name : updated property options from ['--webapp-name'] to ['--webapp-name', '-n'] |
||
webapp config backup update | cmd webapp config backup update update parameter webapp_name : updated property options from ['--webapp-name'] to ['--webapp-name', '-n'] |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
App Service |
Could you add some test cases for these issues? |
Please fix CI issues |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp config backup update
Description
Fixes #29512
Testing Guide
az webapp config backup update -g <> -n <> --retention 60
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.