Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{App Service} Fix #26285: az webapp traffic-routing set: slot truncation to 40 characters #30699

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

seligj95
Copy link
Contributor

@seligj95 seligj95 commented Jan 22, 2025

Related command

az webapp traffic-routing set

Description

Fixes #26285

Host names are truncated based on a character limit. This command forms the hostname, but failed to truncate according to the 40 character limit.

Testing Guide

az webapp traffic-routing set
--resource-group MyResourceGroup
--name this-app-service-has-a-name-that-is-too-long
--distribution predeploy=0

The actionHostParameter should return a truncated value for the app name in the response body.

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

Copy link

Hi @seligj95,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 22, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 22, 2025
@seligj95 seligj95 changed the title {App Service} Fix #26285: az webapp traffic-routing set slot truncation to 40 characters {App Service} Fix #26285: az webapp traffic-routing set slot truncation to 40 characters Jan 29, 2025
@seligj95 seligj95 changed the title {App Service} Fix #26285: az webapp traffic-routing set slot truncation to 40 characters {App Service} Fix #26285: az webapp traffic-routing set: slot truncation to 40 characters Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Web Apps az webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"az webapp traffic-routing set" does not set the correct actionHostName based on truncation rules.
3 participants