[Appconfig] az appconfig kv export/import/list, az appconfig revision list, az appconfig feature list and az appconfig restore: Support filtering by tags
#30694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @ChristineWanjau, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appconfig feature list | cmd appconfig feature list added parameter tags |
||
| appconfig kv export | cmd appconfig kv export added parameter dest_tags |
||
| appconfig kv export | cmd appconfig kv export added parameter tags |
||
| appconfig kv import | cmd appconfig kv import added parameter src_tags |
||
| appconfig kv import | cmd appconfig kv import added parameter tags |
||
| appconfig kv list | cmd appconfig kv list added parameter tags |
||
| appconfig kv restore | cmd appconfig kv restore added parameter tags |
||
| appconfig revision list | cmd appconfig revision list added parameter tags |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
ChristineWanjau
changed the title
az appconfig kv list/ revision list/ feature list/ restore: Support filtering by tags
ChristineWanjau
changed the title
az appconfig kv list/ revision list/ feature list/ restore: Support filtering by tagsaz appconfig kv export/import/list, revision list and feature list/ restore: Support filtering by tags
ChristineWanjau
changed the title
az appconfig kv export/import/list, revision list and feature list/ restore: Support filtering by tagsaz appconfig kv export/import/list, az appconfig revision list, az appconfig feature list and az appconfig restore: Support filtering by tags
ChristineWanjau
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
There was a problem hiding this comment.
Copilot reviewed 28 out of 30 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- src/azure-cli/azure/cli/command_modules/appconfig/keyvalue.py: Evaluated as low risk
- src/azure-cli/azure/cli/command_modules/appconfig/tests/latest/test_appconfig_commands.py: Evaluated as low risk
Comments suppressed due to low confidence (4)
src/azure-cli/azure/cli/command_modules/appconfig/_utils.py:236
- The function should explicitly check if
tagsis a list before processing and validate the format of tags.
def format_tags(tags):
src/azure-cli/azure/cli/command_modules/appconfig/_kv_helpers.py:27
- The import statement for 'format_tags' should be alphabetically ordered with the other imports.
from ._utils import prep_label_filter_for_url_encoding, format_tags
src/azure-cli/azure/cli/command_modules/appconfig/feature.py:300
- [nitpick] The variable name 'tags' is ambiguous. It should be renamed to 'tags_filter' for clarity.
tags=None):
src/azure-cli/azure/cli/command_modules/appconfig/feature.py:1264
- [nitpick] The error message should include the tags to make it clear that the tags were part of the filter criteria. Suggested message: 'Failed to read feature flag(s) that match the specified feature, label, and tags.'
raise CLIErrors.AzureResponseError('Failed to read feature flag(s) that match the specified feature and label. ' + str(exception))
| @@ -166,10 +169,13 @@ def __write_kv_and_features_to_config_store( | |||
| if features: | |||
| key_values.extend(__convert_featureflag_list_to_keyvalue_list(features)) | |||
|
|
|||
| tags = format_tags(tags) | |||
There was a problem hiding this comment.
The 'tags' variable is being reassigned after being passed as a parameter. Use a different variable name for the formatted tags to avoid unexpected behavior.
Suggested change
| tags = format_tags(tags) | |
| formatted_tags = format_tags(tags) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az appconfig restore
az appconfig kv list/export/import
az appconfig revision list
az appconfig feature list
Description
This Pr adds support to filter by tags for restore, revision list, kv list/export/import and feature list commands
Testing Guide
History Notes
[Appconfig]
az appconfig kv export: Support filtering by tags[Appconfig]
az appconfig kv import: Support filtering by tags[Appconfig]
az appconfig kv list: Support filtering by tags[Appconfig]
az appconfig feature list: Support filtering by tags[Appconfig]
az appconfig restore: Support filtering by tags[Appconfig]
az appconfig revision list: Support filtering by tagsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.