Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{RDBMS} az postgres flexible-server parameter set : Fix error message when invalid configuration name or source is provided #30691

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

{RDBMS} az postgres flexible-server parameter set : Fix error message when invalid configuration name or source is provided #30691

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad1b301
Catch error for updatin parameters
nasc17 Jan 22, 2025
4ba587d
lint fix
nasc17 Jan 24, 2025
cfd3c09
Merge remote-tracking branch 'origin/dev2' into nasc/serverParamFix
nasc17 Feb 6, 2025
989baf3
update tests
nasc17 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_custom_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -483,23 +483,29 @@ def flexible_server_postgresql_get(cmd, resource_group_name, server_name):

def flexible_parameter_update(client, server_name, configuration_name, resource_group_name, source=None, value=None):
validate_resource_group(resource_group_name)
if source is None and value is None:
parameter_value = value
parameter_source = source
try:
# validate configuration name
parameter = client.get(resource_group_name, server_name, configuration_name)

# update the command with system default
try:
parameter = client.get(resource_group_name, server_name, configuration_name)
value = parameter.default_value # reset value to default
if parameter_value is None and parameter_source is None:
parameter_value = parameter.default_value # reset value to default

# this should be 'system-default' but there is currently a bug in PG, so keeping as what it is for now
# this should be 'system-default' but there is currently a bug in PG
# this will reset source to be 'system-default' anyway
source = parameter.source
except HttpResponseError as e:
parameter_source = "user-override"
elif parameter_source is None:
parameter_source = "user-override"
except HttpResponseError as e:
if parameter_value is None and parameter_source is None:
raise CLIError('Unable to get default parameter value: {}.'.format(str(e)))
elif source is None:
source = "user-override"
raise CLIError(str(e))

parameters = postgresql_flexibleservers.models.Configuration(
value=value,
source=source
value=parameter_value,
source=parameter_source
)

return client.begin_update(resource_group_name, server_name, configuration_name, parameters)
Expand Down
Loading