Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New stable CLI extension for NetworkCloud APIs 2025-02-01 #8460

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mbashtovaya
Copy link
Member

@mbashtovaya mbashtovaya commented Feb 7, 2025


New stable CLI extension for NetworkCloud APIs 2025-02-01.

The corresponding aaz models: Azure/aaz#686

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @mbashtovaya,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

azure-client-tools-bot-prd bot commented Feb 7, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️networkcloud
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd networkcloud baremetalmachine update cmd networkcloud baremetalmachine update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud baremetalmachine update cmd networkcloud baremetalmachine update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork create cmd networkcloud cloudservicesnetwork create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork create cmd networkcloud cloudservicesnetwork create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork delete cmd networkcloud cloudservicesnetwork delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork delete cmd networkcloud cloudservicesnetwork delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork update cmd networkcloud cloudservicesnetwork update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cloudservicesnetwork update cmd networkcloud cloudservicesnetwork update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset create cmd networkcloud cluster baremetalmachinekeyset create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset create cmd networkcloud cluster baremetalmachinekeyset create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset delete cmd networkcloud cluster baremetalmachinekeyset delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset delete cmd networkcloud cluster baremetalmachinekeyset delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset update cmd networkcloud cluster baremetalmachinekeyset update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster baremetalmachinekeyset update cmd networkcloud cluster baremetalmachinekeyset update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset create cmd networkcloud cluster bmckeyset create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset create cmd networkcloud cluster bmckeyset create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset delete cmd networkcloud cluster bmckeyset delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset delete cmd networkcloud cluster bmckeyset delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset update cmd networkcloud cluster bmckeyset update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster bmckeyset update cmd networkcloud cluster bmckeyset update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter if_none_match
⚠️ 1010 - ParaPropUpdate networkcloud cluster create cmd networkcloud cluster create update parameter managed_resource_group_configuration: updated property options from ['--managed-resource-group-configuration'] to ['--managed-resource-group-configuration', '--mrg']
⚠️ 1006 - ParaAdd networkcloud cluster delete cmd networkcloud cluster delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster delete cmd networkcloud cluster delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration create cmd networkcloud cluster metricsconfiguration create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration create cmd networkcloud cluster metricsconfiguration create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration delete cmd networkcloud cluster metricsconfiguration delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration delete cmd networkcloud cluster metricsconfiguration delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration update cmd networkcloud cluster metricsconfiguration update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster metricsconfiguration update cmd networkcloud cluster metricsconfiguration update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud clustermanager create cmd networkcloud clustermanager create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud clustermanager create cmd networkcloud clustermanager create added parameter if_none_match
⚠️ 1010 - ParaPropUpdate networkcloud clustermanager create cmd networkcloud clustermanager create update parameter managed_resource_group_configuration: updated property options from ['--managed-resource-group-configuration'] to ['--managed-resource-group-configuration', '--mrg']
⚠️ 1006 - ParaAdd networkcloud clustermanager delete cmd networkcloud clustermanager delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud clustermanager delete cmd networkcloud clustermanager delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud clustermanager identity assign cmd networkcloud clustermanager identity assign added parameter if_match
⚠️ 1006 - ParaAdd networkcloud clustermanager identity assign cmd networkcloud clustermanager identity assign added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud clustermanager identity remove cmd networkcloud clustermanager identity remove added parameter if_match
⚠️ 1006 - ParaAdd networkcloud clustermanager identity remove cmd networkcloud clustermanager identity remove added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud clustermanager update cmd networkcloud clustermanager update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud clustermanager update cmd networkcloud clustermanager update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool create cmd networkcloud kubernetescluster agentpool create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool create cmd networkcloud kubernetescluster agentpool create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool delete cmd networkcloud kubernetescluster agentpool delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool delete cmd networkcloud kubernetescluster agentpool delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool update cmd networkcloud kubernetescluster agentpool update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster agentpool update cmd networkcloud kubernetescluster agentpool update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster create cmd networkcloud kubernetescluster create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster create cmd networkcloud kubernetescluster create added parameter if_none_match
⚠️ 1010 - ParaPropUpdate networkcloud kubernetescluster create cmd networkcloud kubernetescluster create update parameter managed_resource_group_configuration: updated property options from ['--managed-resource-group-configuration'] to ['--managed-resource-group-configuration', '--mrg']
⚠️ 1006 - ParaAdd networkcloud kubernetescluster delete cmd networkcloud kubernetescluster delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster delete cmd networkcloud kubernetescluster delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster feature create cmd networkcloud kubernetescluster feature create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster feature create cmd networkcloud kubernetescluster feature create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster feature delete cmd networkcloud kubernetescluster feature delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster feature delete cmd networkcloud kubernetescluster feature delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster feature update cmd networkcloud kubernetescluster feature update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster feature update cmd networkcloud kubernetescluster feature update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster update cmd networkcloud kubernetescluster update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud kubernetescluster update cmd networkcloud kubernetescluster update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud l2network create cmd networkcloud l2network create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud l2network create cmd networkcloud l2network create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud l2network delete cmd networkcloud l2network delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud l2network delete cmd networkcloud l2network delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud l2network update cmd networkcloud l2network update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud l2network update cmd networkcloud l2network update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud l3network create cmd networkcloud l3network create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud l3network create cmd networkcloud l3network create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud l3network delete cmd networkcloud l3network delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud l3network delete cmd networkcloud l3network delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud l3network update cmd networkcloud l3network update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud l3network update cmd networkcloud l3network update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud rack update cmd networkcloud rack update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud rack update cmd networkcloud rack update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud storageappliance update cmd networkcloud storageappliance update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud storageappliance update cmd networkcloud storageappliance update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud trunkednetwork create cmd networkcloud trunkednetwork create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud trunkednetwork create cmd networkcloud trunkednetwork create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud trunkednetwork delete cmd networkcloud trunkednetwork delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud trunkednetwork delete cmd networkcloud trunkednetwork delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud trunkednetwork update cmd networkcloud trunkednetwork update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud trunkednetwork update cmd networkcloud trunkednetwork update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine console create cmd networkcloud virtualmachine console create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine console create cmd networkcloud virtualmachine console create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine console delete cmd networkcloud virtualmachine console delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine console delete cmd networkcloud virtualmachine console delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine console update cmd networkcloud virtualmachine console update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine console update cmd networkcloud virtualmachine console update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine create cmd networkcloud virtualmachine create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine create cmd networkcloud virtualmachine create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine delete cmd networkcloud virtualmachine delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine delete cmd networkcloud virtualmachine delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine update cmd networkcloud virtualmachine update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud virtualmachine update cmd networkcloud virtualmachine update added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud volume create cmd networkcloud volume create added parameter if_match
⚠️ 1006 - ParaAdd networkcloud volume create cmd networkcloud volume create added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud volume delete cmd networkcloud volume delete added parameter if_match
⚠️ 1006 - ParaAdd networkcloud volume delete cmd networkcloud volume delete added parameter if_none_match
⚠️ 1006 - ParaAdd networkcloud volume update cmd networkcloud volume update added parameter if_match
⚠️ 1006 - ParaAdd networkcloud volume update cmd networkcloud volume update added parameter if_none_match

Copy link

Hi @mbashtovaya,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

github-actions bot commented Feb 7, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 7, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Feb 7, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Feb 7, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 7, 2025
@mbashtovaya
Copy link
Member Author

Hi @mbashtovaya

⚠️ Release Requirements

Module: networkcloud

  • ⚠️ Please update VERSION to be 3.0.0b2 in src/networkcloud/setup.py
  • ⚠️ Set azext.isPreview to true in azext_metadata.json for networkcloud

Notes

we are promoting the stable CLI

@yonzhan yonzhan requested review from kairu-ms and jsntcy February 8, 2025 00:46
@AllyW AllyW added the stable release extension module as stable label Feb 8, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 8, 2025
@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@mbashtovaya
Copy link
Member Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 8460 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 12, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge stable release extension module as stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants