-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Support for ARM in OpenAPI to TypeSpec Conversion #4777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/changes/@autorest/openapi-to-cadl/arm-conversion_2023-10-02-17-10.json
Outdated
Show resolved
Hide resolved
packages/extensions/openapi-to-cadl/src/generate/generate-arm-resource.ts
Outdated
Show resolved
Hide resolved
packages/extensions/openapi-to-cadl/test/arm-sphere/tsp-output/tspconfig.yaml
Outdated
Show resolved
Hide resolved
packages/extensions/openapi-to-cadl/test/arm-sphere/tsp-output/routes.tsp
Outdated
Show resolved
Hide resolved
Fix failing generation on windows
As people are already using the converter for Swagger to TypeSpec conversion, let's try to merge this PR to avoid its growing larger and become more difficult to maintain. Thanks |
lirenhe
reviewed
Dec 21, 2023
common/changes/@autorest/openapi-to-cadl/arm-conversion_2023-10-02-17-10.json
Outdated
Show resolved
Hide resolved
lirenhe
reviewed
Dec 21, 2023
lirenhe
reviewed
Dec 21, 2023
lirenhe
reviewed
Dec 21, 2023
lirenhe
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the initial effort to integrate ARM (Azure Resource Manager) support into the OpenAPI to TypeSpec plugin. Utilizing the
@typespec/azure-resource-manager
library, we now generate TypeSpec representations of Azure resources. A subsequent PR will address the definition of Resource operations.Overview:
Consuming Resource Metadata (
resources.json
):Per-Resource tsp File Generation:
@typespec/azure-resource-manager
.Reutilizing Data Plane Conversion Logic:
Upcoming Work:
@typespec/azure-resource-manager
.routes.tsp
file, as operations are defined alongside the resources. However, this file remains relevant and necessary for data plane spec conversions.