Preserve host header even with extra trusted root certificates #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismilson
changed the title
|
@microsoft-github-policy-service agree |
chrismilson
commented
Apr 3, 2023
|
Not sure how to get the Merge Builds check to succeed - error message is pretty non-descriptive. |
chrismilson
commented
Apr 21, 2023
| httpSettings.PickHostNameFromBackendAddress = to.BoolPtr(true) | ||
| if overrideBackendHostName, err := annotations.OverrideBackendHostName(backendID.Ingress); err == nil { | ||
| if httpSettings.HostName != nil && !overrideBackendHostName { | ||
| // TODO Warn about pointless setting of hostname |
There was a problem hiding this comment.
Not sure what the best way to implement this warning would be. Help would be appreciated.
The new annotation corresponds to the "Override with new host name" option in the backend settings blade in the Azure Portal.
chrismilson
force-pushed
the
preserve-host-header
branch
from
1ccfb6b to
594d717
Compare
|
@akshaysngupta @alxyzc Could I please get a review? |
|
PLEASE MERGE |
|
@akshaysngupta @alxyzc is this project dead? |
estenssoros
approved these changes
Feb 5, 2025
|
@estenssoros please merge |
|
@akshaysngupta please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Fixes.Description
/override-backend-hostname;Fixes
#1520