Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(designer): Introduce chunk text with metadata action #6764

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abhargavams
Copy link

@abhargavams abhargavams commented Mar 11, 2025

Type of Change

  • Bug fix
  • Feature
  • Other

Current Behavior

New Behavior

Impact of Change

  • This is a breaking change.

Test Plan

Screenshots or Videos (if applicable)

@abhargavams abhargavams requested a review from hartra344 as a code owner March 11, 2025 06:51
@@ -125,6 +125,7 @@ const edifactbatchencode = 'edifactbatchencode';
const edifactdecode = 'edifactdecode';
const parsedocument = 'parsedocument';
const parsedocumentwithmetadata = 'parsedocumentwithmetadata';
const chunktextwithmetadata = 'chunktextwithmetadata';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this present both in standard and consumption? If you make changes here it is assumed it is prsent in both places.
and i have not seen any entry for this in consumption data

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please tell where to do the changes if we have to go only for standard.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to create similar object in standard/operationmanifest.ts service implementation like how we have for consumption inside consumption/operationmanifest.ts for supportedTypes and manifestObjects.

Currently consumption is a super set of all types supported in standard, hence we didnt have any new object. But please follow that to create else this will also show up in consumption and might fail workflow runtime.

@ccastrotrejo ccastrotrejo changed the title changes for chunk text with metadara feat(designer): Introduce chunk text with metadata action Mar 11, 2025
@abhargavams abhargavams requested a review from preetriti1 March 20, 2025 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants