Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode): Update Auth method #6014

Merged
merged 9 commits into from
Nov 1, 2024
Merged

Conversation

ccastrotrejo
Copy link
Contributor

@ccastrotrejo ccastrotrejo commented Nov 1, 2024

This pull request primarily focuses on removing the use of ServiceClientCredentials and simplifying the authorization token retrieval process across various files. Additionally, it includes the addition of a new dependency in the package.json file.

This PR updates our auth method for the upcoming deprecation of the azure-account vscode extension as stated in microsoft/vscode-azure-account#964

  • Removed the use of ServiceClientCredentials and simplified the getAuthorizationToken function call.
  • Added @microsoft/vscode-azext-azureauth version 3.0.0 to the dependencies.
  • Removed the Azure Account extension from the list of required Visual Studio Code extensions.

Screenshots

When logged out from Azure Resources vscode identifies we also use those crendentials

Screenshot 2024-11-01 at 9 28 06 AM

When user doesn't consent to login when trying to get acesstoken, user will see the following error

Screenshot 2024-11-01 at 9 28 54 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants