refactor(look&feel): select native #888
Conversation
fffan64
force-pushed
the
refactor/select-native
branch
2 times, most recently
from
86eb66f to
f9276ed
Compare
fffan64
force-pushed
the
refactor/select-native
branch
from
f9276ed to
fcdb314
Compare
fffan64
force-pushed
the
refactor/select-native
branch
from
fcdb314 to
a40df1b
Compare
| </option> | ||
| )} | ||
| {options.map((o) => ( | ||
| <option key={o.label} value={o.value}> |
There was a problem hiding this comment.
On ne devrait pas mettre la clé sur la value plutot ?
There was a problem hiding this comment.
je c pas, l'un ou l'autre rien ne garanti que c unique de toute façon
There was a problem hiding this comment.
@buddyvegas m'a conseille de faire combo label - value.
fffan64
force-pushed
the
refactor/select-native
branch
2 times, most recently
from
3423f63 to
c830a68
Compare
| </option> | ||
| )} | ||
| {options.map((o) => ( | ||
| <option key={`${o.label}-${o.value}`} value={o.value}> |
There was a problem hiding this comment.
au risque de changer l'implem mias pourquoi ne pas ce rattrocher de la syntaxe html natif a savoir de d'avoir un composant Options
<Select>
<Option>option 1 </Option>
<Option>option 2 </Option>
<Option>option 3 </Option>
<Option>option 3 </Option>
</Select>
```
ce qui permet à nous de plus gérer la key et serait au consommateur de gérer
qu'en penses tu ?There was a problem hiding this comment.
en faisant comme ca tu peux pas avoir de placeholder
There was a problem hiding this comment.
ca serait au consommateur de le gérer parce que le placeholder sur un sélection c'est une option avec une value vide
There was a problem hiding this comment.
ok, j'ai change pour aller dans ce sens
fffan64
dismissed stale reviews from a-pourrier and GuillaumeKESTEMAN
via
df4e23e
fffan64
force-pushed
the
refactor/select-native
branch
from
c830a68 to
df4e23e
Compare
fffan64
force-pushed
the
refactor/select-native
branch
from
df4e23e to
ff383c9
Compare
removed react-select dep to implement native select instead
as you know, options are not (yet!) stylable as they are managed by os
breaking from current implementation (value returned is now normal value of options instead of previous {label; value} of react-select)