Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add livret a icon #880

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pavannani99
Copy link

Livret A Savings Account Icon

Resolves #873

Changes

  • Added SVG icon file
  • Created React component
  • Integrated with Storybook
  • Follows AXA design system patterns

Verification

  • Icon renders correctly
  • Color inheritance works
  • Accessibility attributes present

Maintainers: Please verify Storybook integration.

@GuillaumeKESTEMAN
Copy link
Contributor

GuillaumeKESTEMAN commented Feb 17, 2025

A SVG component exists to render SVG files.
You can export you SVG file and use that component i think.
Also, are you sure that svg is not present in the material symbols svg library ?

@pavannani99
Copy link
Author

A SVG component exists to render SVG files. You can export you SVG file and use that component i think. Also, are you sure that svg is not present in the material symbols svg library ?

Thank you for pointing this out!

Material Symbols Check:
I’ll verify if the livret-a icon exists in the Material Symbols library. If it does, I’ll replace the custom SVG with the existing one from the library.

Using the SVG Component:
If the icon isn’t available in Material Symbols, I’ll refactor the PR to use the project’s existing component instead of adding a raw SVG file.

Scope Clarification:
Just to confirm: Is this PR meant to add tests (as per the original issue) or add an icon? If it’s about tests, I’ll close this PR and submit a new one focused solely on testing.

I appreciate your guidance here! Let me know if you’d like me to proceed with the icon changes or pivot to testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Look&feel] [Test] Add tests for the Select, CustomOptions and DropdownIndicator components
3 participants