Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(look&feel): radio and checkbox css clip-path for safari #856

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

fffan64
Copy link
Contributor

@fffan64 fffan64 commented Feb 13, 2025

on safari (at least on iPad and iPhone it seems) the checkbox and radio button svg are not displayed correctly.
this is because the css use clip-path to delimit the svg to allow only to set the background color to white properly.

image

thing is i have no safari able devices to test this myself, sorry.

buddyvegas
buddyvegas previously approved these changes Feb 13, 2025
@GuillaumeKESTEMAN
Copy link
Contributor

Hello,
Je veux bien que tu expliques un peu comment ça fonctionne car je ne vois que deux lignes dupliquées en plus.
En quoi cela corrige le problème sur Safari ?

@fffan64
Copy link
Contributor Author

fffan64 commented Feb 14, 2025

m

Hello, Je veux bien que tu expliques un peu comment ça fonctionne car je ne vois que deux lignes dupliquées en plus. En quoi cela corrige le problème sur Safari ?

mdr jai push le mauvais truc v modif sorry ...

@fffan64
Copy link
Contributor Author

fffan64 commented Feb 14, 2025

m

Hello, Je veux bien que tu expliques un peu comment ça fonctionne car je ne vois que deux lignes dupliquées en plus. En quoi cela corrige le problème sur Safari ?

mdr jai push le mauvais truc v modif sorry ...

ca devrai etre mieux now, desole :D

@@ -150,6 +150,7 @@
& svg {
background-color: var(--color-white);
clip-path: inset(0.22rem round 2px);
-webkit-clip-path: inset(0.22rem round 2px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question ouverte non bloquante, il ne serait pas utilise d'utiliser l'autoprefixer avec postcss, pour éviter ce genre de cas ?

@fffan64 fffan64 merged commit c54bed4 into AxaFrance:main Feb 17, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants