Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] remove Odoo codebase and uninstallable modules #1053

Open
wants to merge 2 commits into
base: 9.0
Choose a base branch
from

Conversation

paulRbr
Copy link

@paulRbr paulRbr commented Jun 25, 2020

This PR cleans up the repository by:

🧹

@paulRbr
Copy link
Author

paulRbr commented Dec 17, 2020

Hi @ivantodorovich, I believe keeping the whole codebase of the Odoo project inside this repository can be quite “daunting” for beginners, and also error prone as the codebase of Odoo is maintain separately here: https://github.com/odoo/odoo/tree/9.0.

Do you see any problem to merge this PR please?

Thanks!

@ivantodorovich
Copy link
Contributor

ivantodorovich commented Dec 17, 2020

Hi @paulRbr

I totally agree with you, that is why in the 12.0 branch we've aligned -as much as possible- to the OCA guidelines, by:

  • Removing OCA clones from the repo
  • Moving customizations made to OCA modules to specific modules
  • Flatten repository structure
  • Add tests (LINT + odoo test)

However the migration wasn't finished and we're not working on this project anymore. It's being maintained by @AwesomeFoodCoops/trobz now

In any case, regarding this PR, beware in 9.0 some foodcoops customizations were done in odoo source code. So you can't just remove it without identifying them and moving them to modules (I believe it's l10n_fr_fec, if my memory doesn't fail).

We've analized this at some point and decided that it was too big of a risk for 9.0, given that there are many databases in production, and the way to move forward would be to start things clean in 12.0

@paulRbr
Copy link
Author

paulRbr commented Jan 12, 2021

Hi @ivantodorovich thank you very much for your answer 🙇.

Do you know who I could talk to directly to be able to asses the customizations made in the odoo codebase?

We are a few volunteers from the forum.supermarches-cooperatifs.fr community who wish to work on aligning the v9.0 of a few french food coops codebases and that would mean align to the “La Louve” latest codebase.

If you don't mind, may I send you a direct email to be able to ask you some questions?

Many thanks!

@ivantodorovich
Copy link
Contributor

Hi @paulRbr !

You can look at the commit history in the odoo directory: https://github.com/AwesomeFoodCoops/odoo-production/commits/9.0/odoo. You'll see that there are a few changes done in core. Not much, I agree.. The whole solution probably works without them..

I'm not sure how I'd be able to help, but feel free to contact me :)

@remi-filament
Copy link
Contributor

Hi @paulRbr
This morning my PR #946 was closed, and I found out yours :)
I agree that odoo code should not be here in the first place, however there could be good reasons for keeping it :

  • this allows to have a specific version of the source code, the same for every foodcoop, otherwise you could have coops using different version/commit of the source code, making it more difficult to maintain / trace issues - this could be however done with a submodule pointing to a specific version of odoo code
  • also, you have to take into consideration that Odoo v9 code is not maintained anymore since v12 is out (2,5 year ago already) - Odoo only maintains the 3 last versions of its code - OCA kinds of still maintain this code by backporting the security fixes to older versions as done beginning of this year by Stefan on v9 here : https://github.com/OCA/OCB/tree/9.0

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants