Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opening-a-dialog.md #577

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Update opening-a-dialog.md #577

merged 3 commits into from
Dec 19, 2024

Conversation

bitwool
Copy link
Contributor

@bitwool bitwool commented Nov 19, 2024

In the document for the music app store in version 11.0.x, the code fails to compile.
InteractionContext should be replaced with IInteractionContext.

@timunie
Copy link
Contributor

timunie commented Dec 11, 2024

Could you add a note (where the interface is introduced) that this code is only valid in newer ReactiveUI which is shipped since 11.2.0?

Thank you.

@bitwool
Copy link
Contributor Author

bitwool commented Dec 14, 2024

@timunie I have finished adding note, but I'm not sure if it fits your expectations.

@timunie
Copy link
Contributor

timunie commented Dec 19, 2024

Sorry for the delay. LGTM! Thx for your contribution.

@timunie timunie merged commit 165ea51 into AvaloniaUI:main Dec 19, 2024
2 checks passed
@timunie timunie mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants